[RUST] Fix #22356 / Introduce useSerdePathToError option to improve JSON error messages#22357
Conversation
|
👋 @frol @farcaller @richardwhiuk @paladinzh @jacob-pro @dsteeley let me know if this looks good to you, any and all feedback would be appreciated 🙇 |
|
thanks for the PR
if that's the case, shall we add this feature without the option to start with as it should benefit everyone using the auto-generated Rust SDK? |
@wing328 Thanks for the quick response! I was considering that as well. I'm erring on the conservative side for three reasons:
|
|
looks good to me let's give it a try thanks for your contribution |
…n to improve JSON error messages (OpenAPITools#22357) * Add CLI option * Add dep to generated Cargo.toml * Add new `Error::SerdePathToError` error type * Add `serde_path_to_error` invocation to API layer * Add sample for serde-path-to-error * Add arg & docstring to cliOptions as well * Fix sample
This PR contains the proposed solution to #22356 - introducing an optional
useSerdePathToErrorconfig option for the Rust generator (defaulting to false) that adds theserde_path_to_errorlibrary for improving Serde error responses. The linked issue contains an example before / after error message.Change breakdown:
useSerdePathToErrorconfig option to the Rust generatorserde_path_to_error = "^0.1"dependencySerdePathToErrorerror type and all appropriate methodsserde_json::from_strand the appropriateserde_path_to_errorequivalentsamples/client/petstore/rust/reqwest/petstore-serde-path-to-errorNotably, I'm leaving the 4XX/5XX-path
serde_json::from_struntouched. This path will include the both the received raw response body and (if parseable) the JSON response body. This should improve debug-ability sufficiently to not need this additional library.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)