[typescript-angular] fix integration tests#22463
Conversation
The expected files where not the correct ones.
|
thanks for the PR let's give it a try |
@gonzalad thanks again for the PR Do you mind sharing the exact commands to update these files so that we can reuse moving forward? |
|
@wing328 alas, I didn't use any commands for that, I simply checked that the files in the target/-results folder where good one and copied the manually to src/test/resources//expected folder. The fundamental approach of those integration tests is brittle, but I don't see how to fix that. |
|
thanks for sharing more. i think what i'll do is to replace these tests with something else that can be more easily understood by developers on what's wrong or what's changed. |
|
fyi .merged #22501 to disable the tests as it's causing false alarms in the master |
The expected files where not the correct ones.
The expected files where not the correct ones.
This little PR fixes typescript angular integration test and reactivates them.
The expected files where not the correct ones.
Asking for review:
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10)
Thanks,
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)