Skip to content

Jackson deserializers fail when FAIL_ON_TRAILING_TOKENS is enabled due to parser.readValueAsTree() #23147

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
wendigo:serafin/fix-reading-of-json-trees
Mar 6, 2026
Merged

Jackson deserializers fail when FAIL_ON_TRAILING_TOKENS is enabled due to parser.readValueAsTree() #23147
wing328 merged 2 commits intoOpenAPITools:masterfrom
wendigo:serafin/fix-reading-of-json-trees

Conversation

@wendigo
Copy link
Copy Markdown
Contributor

@wendigo wendigo commented Mar 5, 2026

Fixes #23146

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Use DeserializationContext.readTree(jp) instead of JsonParser.readValueAsTree() to fix oneOf/anyOf deserialization failures when FAIL_ON_TRAILING_TOKENS is enabled. Updates jersey2, jersey3, and native Java generators and regenerates Java samples; fixes #23146.

Written for commit 0cb0089. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

@wendigo wendigo changed the title Fix incorrect tree parsing with Jackson Jackson deserializers fail when FAIL_ON_TRAILING_TOKENS is enabled due to parser.readValueAsTree() Mar 5, 2026
@wendigo
Copy link
Copy Markdown
Contributor Author

wendigo commented Mar 5, 2026

@wing328
Copy link
Copy Markdown
Member

wing328 commented Mar 6, 2026

when FAIL_ON_TRAILING_TOKENS is enabled

I assume you've tested this fix when FAIL_ON_TRAILING_TOKENS is enabled.

Did you have a chance to test your fix when FAIL_ON_TRAILING_TOKENS is disabled?

Just want to make sure there's no regression when FAIL_ON_TRAILING_TOKENS is disabled.

As usual, thanks for the PR

@wendigo
Copy link
Copy Markdown
Contributor Author

wendigo commented Mar 6, 2026

@wing328 yes to both answers. Actually the only correct way to parse subtrees is in the proposed fix. This works for both top-level objects and nested ones.

@wing328 wing328 merged commit 2d82875 into OpenAPITools:master Mar 6, 2026
90 checks passed
@wing328
Copy link
Copy Markdown
Member

wing328 commented Mar 6, 2026

thanks for the confirmation.

just merged it. have a nice weekend

@wendigo
Copy link
Copy Markdown
Contributor Author

wendigo commented Mar 6, 2026

@wing328 thanks! you too

@wendigo wendigo deleted the serafin/fix-reading-of-json-trees branch March 6, 2026 14:19
davidricodias pushed a commit to davidricodias/openapi-generator that referenced this pull request Mar 11, 2026
…e to parser.readValueAsTree() (OpenAPITools#23147)

* Fix incorrect tree parsing with Jackson

* Regenerate Java samples
@wendigo
Copy link
Copy Markdown
Contributor Author

wendigo commented Mar 24, 2026

Tested on released version - still works. Thanks @wing328 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [Java] Jackson deserializers fail when FAIL_ON_TRAILING_TOKENS is enabled due to parser.readValueAsTree()

2 participants