Jackson deserializers fail when FAIL_ON_TRAILING_TOKENS is enabled due to parser.readValueAsTree() #23147
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Mar 6, 2026
Conversation
Contributor
Author
Member
I assume you've tested this fix when FAIL_ON_TRAILING_TOKENS is enabled. Did you have a chance to test your fix when FAIL_ON_TRAILING_TOKENS is disabled? Just want to make sure there's no regression when FAIL_ON_TRAILING_TOKENS is disabled. As usual, thanks for the PR |
Contributor
Author
|
@wing328 yes to both answers. Actually the only correct way to parse subtrees is in the proposed fix. This works for both top-level objects and nested ones. |
Member
|
thanks for the confirmation. just merged it. have a nice weekend |
Contributor
Author
|
@wing328 thanks! you too |
davidricodias
pushed a commit
to davidricodias/openapi-generator
that referenced
this pull request
Mar 11, 2026
…e to parser.readValueAsTree() (OpenAPITools#23147) * Fix incorrect tree parsing with Jackson * Regenerate Java samples
Contributor
Author
|
Tested on released version - still works. Thanks @wing328 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23146
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Use DeserializationContext.readTree(jp) instead of JsonParser.readValueAsTree() to fix oneOf/anyOf deserialization failures when FAIL_ON_TRAILING_TOKENS is enabled. Updates jersey2, jersey3, and native Java generators and regenerates Java samples; fixes #23146.
Written for commit 0cb0089. Summary will update on new commits.