Skip to content

Use Pydantic for json serialization in .to_json method#23210

Merged
wing328 merged 4 commits intomasterfrom
RagnaRockGeo-fix_python_to_json_with_uuid
Mar 12, 2026
Merged

Use Pydantic for json serialization in .to_json method#23210
wing328 merged 4 commits intomasterfrom
RagnaRockGeo-fix_python_to_json_with_uuid

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Mar 12, 2026

based on #22111 with updated samples

cc @cbornet (2017/09) @tomplus (2018/10) @krjakbrjak (2023/02) @fa0311 (2023/10) @multani (2023/10)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Fixes Python model JSON serialization by converting non-standard types to JSON-safe data in to_json(). Generated Python models now emit valid JSON for UUIDs and more.

  • Bug Fixes
    • Use pydantic_core.to_jsonable_python in to_json() to convert self.to_dict() before json.dumps.
    • Regenerated Python samples (echo_api and petstore python-aiohttp) to reflect the change.

Written for commit 520434f. Summary will update on new commits.

@wing328 wing328 changed the title Ragna rock geo fix python to json with UUID Use Pydantic for json serialization in .to_json method Mar 12, 2026
@wing328 wing328 marked this pull request as ready for review March 12, 2026 01:06
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 397 files

Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.

@wing328 wing328 added this to the 7.21.0 milestone Mar 12, 2026
@wing328 wing328 merged commit 4603cc9 into master Mar 12, 2026
46 of 47 checks passed
@wing328 wing328 deleted the RagnaRockGeo-fix_python_to_json_with_uuid branch March 12, 2026 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants