Skip to content

Improve consumption of primitive types as body #23257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 4 commits into from
Mar 15, 2026
Merged

Improve consumption of primitive types as body #23257

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f16218
Adapt textual content body to support primitive types.
noordawod Mar 15, 2026
1644695
Regenerate source codes.
noordawod Mar 15, 2026
34ac85a
Move `content` variable into `when`.
noordawod Mar 15, 2026
40b7d40
Accept also `Char` as a possible text body.
noordawod Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ...rc/main/resources/kotlin-client/libraries/jvm-okhttp/infrastructure/ApiClient.kt.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,8 +323,15 @@ import com.squareup.moshi.adapter
.toRequestBody((mediaType ?: JSON_MEDIA_TYPE).toMediaTypeOrNull())
}
mediaType == XML_MEDIA_TYPE -> throw UnsupportedOperationException("xml not currently supported.")
mediaType == TEXT_MEDIA_TYPE && content is String ->
content.toRequestBody(TEXT_MEDIA_TYPE.toMediaTypeOrNull())
mediaType == TEXT_MEDIA_TYPE -> {
val textualContent = when {
content is CharSequence -> content.toString()
content is Number -> content.toString()
content is Boolean -> content.toString()
else -> throw UnsupportedOperationException("requestBody currently only supports text body containing primitive types: characters, numbers, or booleans.")
}
textualContent.toRequestBody(mediaType.toMediaTypeOrNull())
}
// TODO: this should be extended with other serializers
else -> throw UnsupportedOperationException("requestBody currently only supports JSON body, text body, byte body and File body.")
}
Expand Down
11 changes: 9 additions & 2 deletions ...api/kotlin-jvm-okhttp/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,15 @@ open class ApiClient(val baseUrl: String, val client: Call.Factory = defaultClie
.toRequestBody((mediaType ?: JSON_MEDIA_TYPE).toMediaTypeOrNull())
}
mediaType == XML_MEDIA_TYPE -> throw UnsupportedOperationException("xml not currently supported.")
mediaType == TEXT_MEDIA_TYPE && content is String ->
content.toRequestBody(TEXT_MEDIA_TYPE.toMediaTypeOrNull())
mediaType == TEXT_MEDIA_TYPE -> {
val textualContent = when {
content is CharSequence -> content.toString()
Comment thread
noordawod marked this conversation as resolved.
Outdated
content is Number -> content.toString()
content is Boolean -> content.toString()
else -> throw UnsupportedOperationException("requestBody currently only supports text body containing primitive types: characters, numbers, or booleans.")
}
textualContent.toRequestBody(mediaType.toMediaTypeOrNull())
}
// TODO: this should be extended with other serializers
else -> throw UnsupportedOperationException("requestBody currently only supports JSON body, text body, byte body and File body.")
}
Expand Down
11 changes: 9 additions & 2 deletions ...s/kotlin-integer-enum/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,15 @@ open class ApiClient(val baseUrl: String, val client: Call.Factory = defaultClie
.toRequestBody((mediaType ?: JSON_MEDIA_TYPE).toMediaTypeOrNull())
}
mediaType == XML_MEDIA_TYPE -> throw UnsupportedOperationException("xml not currently supported.")
mediaType == TEXT_MEDIA_TYPE && content is String ->
content.toRequestBody(TEXT_MEDIA_TYPE.toMediaTypeOrNull())
mediaType == TEXT_MEDIA_TYPE -> {
val textualContent = when {
content is CharSequence -> content.toString()
content is Number -> content.toString()
content is Boolean -> content.toString()
else -> throw UnsupportedOperationException("requestBody currently only supports text body containing primitive types: characters, numbers, or booleans.")
}
textualContent.toRequestBody(mediaType.toMediaTypeOrNull())
}
// TODO: this should be extended with other serializers
else -> throw UnsupportedOperationException("requestBody currently only supports JSON body, text body, byte body and File body.")
}
Expand Down
11 changes: 9 additions & 2 deletions ...ttp-non-ascii-headers/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,15 @@ open class ApiClient(val baseUrl: String, val client: Call.Factory = defaultClie
.toRequestBody((mediaType ?: JSON_MEDIA_TYPE).toMediaTypeOrNull())
}
mediaType == XML_MEDIA_TYPE -> throw UnsupportedOperationException("xml not currently supported.")
mediaType == TEXT_MEDIA_TYPE && content is String ->
content.toRequestBody(TEXT_MEDIA_TYPE.toMediaTypeOrNull())
mediaType == TEXT_MEDIA_TYPE -> {
val textualContent = when {
content is CharSequence -> content.toString()
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.
Outdated
content is Number -> content.toString()
content is Boolean -> content.toString()
else -> throw UnsupportedOperationException("requestBody currently only supports text body containing primitive types: characters, numbers, or booleans.")
}
textualContent.toRequestBody(mediaType.toMediaTypeOrNull())
}
// TODO: this should be extended with other serializers
else -> throw UnsupportedOperationException("requestBody currently only supports JSON body, text body, byte body and File body.")
}
Expand Down
11 changes: 9 additions & 2 deletions ...khttp-parameter-tests/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,15 @@ open class ApiClient(val baseUrl: String, val client: Call.Factory = defaultClie
.toRequestBody((mediaType ?: JSON_MEDIA_TYPE).toMediaTypeOrNull())
}
mediaType == XML_MEDIA_TYPE -> throw UnsupportedOperationException("xml not currently supported.")
mediaType == TEXT_MEDIA_TYPE && content is String ->
content.toRequestBody(TEXT_MEDIA_TYPE.toMediaTypeOrNull())
mediaType == TEXT_MEDIA_TYPE -> {
val textualContent = when {
content is CharSequence -> content.toString()
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.
Outdated
content is Number -> content.toString()
content is Boolean -> content.toString()
else -> throw UnsupportedOperationException("requestBody currently only supports text body containing primitive types: characters, numbers, or booleans.")
}
textualContent.toRequestBody(mediaType.toMediaTypeOrNull())
}
// TODO: this should be extended with other serializers
else -> throw UnsupportedOperationException("requestBody currently only supports JSON body, text body, byte body and File body.")
}
Expand Down
11 changes: 9 additions & 2 deletions ...-okhttp-path-comments/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,15 @@ open class ApiClient(val baseUrl: String, val client: Call.Factory = defaultClie
.toRequestBody((mediaType ?: JSON_MEDIA_TYPE).toMediaTypeOrNull())
}
mediaType == XML_MEDIA_TYPE -> throw UnsupportedOperationException("xml not currently supported.")
mediaType == TEXT_MEDIA_TYPE && content is String ->
content.toRequestBody(TEXT_MEDIA_TYPE.toMediaTypeOrNull())
mediaType == TEXT_MEDIA_TYPE -> {
val textualContent = when {
content is CharSequence -> content.toString()
content is Number -> content.toString()
content is Boolean -> content.toString()
else -> throw UnsupportedOperationException("requestBody currently only supports text body containing primitive types: characters, numbers, or booleans.")
}
textualContent.toRequestBody(mediaType.toMediaTypeOrNull())
}
// TODO: this should be extended with other serializers
else -> throw UnsupportedOperationException("requestBody currently only supports JSON body, text body, byte body and File body.")
}
Expand Down
11 changes: 9 additions & 2 deletions ...kotlinx-serialization/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,15 @@ open class ApiClient(val baseUrl: String, val client: Call.Factory = defaultClie
.toRequestBody((mediaType ?: JSON_MEDIA_TYPE).toMediaTypeOrNull())
}
mediaType == XML_MEDIA_TYPE -> throw UnsupportedOperationException("xml not currently supported.")
mediaType == TEXT_MEDIA_TYPE && content is String ->
content.toRequestBody(TEXT_MEDIA_TYPE.toMediaTypeOrNull())
mediaType == TEXT_MEDIA_TYPE -> {
val textualContent = when {
content is CharSequence -> content.toString()
content is Number -> content.toString()
content is Boolean -> content.toString()
else -> throw UnsupportedOperationException("requestBody currently only supports text body containing primitive types: characters, numbers, or booleans.")
}
textualContent.toRequestBody(mediaType.toMediaTypeOrNull())
}
// TODO: this should be extended with other serializers
else -> throw UnsupportedOperationException("requestBody currently only supports JSON body, text body, byte body and File body.")
}
Expand Down
11 changes: 9 additions & 2 deletions ...n-allOf-discriminator/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,15 @@ open class ApiClient(val baseUrl: String, val client: Call.Factory = defaultClie
.toRequestBody((mediaType ?: JSON_MEDIA_TYPE).toMediaTypeOrNull())
}
mediaType == XML_MEDIA_TYPE -> throw UnsupportedOperationException("xml not currently supported.")
mediaType == TEXT_MEDIA_TYPE && content is String ->
content.toRequestBody(TEXT_MEDIA_TYPE.toMediaTypeOrNull())
mediaType == TEXT_MEDIA_TYPE -> {
val textualContent = when {
content is CharSequence -> content.toString()
content is Number -> content.toString()
content is Boolean -> content.toString()
Comment thread
noordawod marked this conversation as resolved.
Outdated
else -> throw UnsupportedOperationException("requestBody currently only supports text body containing primitive types: characters, numbers, or booleans.")
}
textualContent.toRequestBody(mediaType.toMediaTypeOrNull())
}
// TODO: this should be extended with other serializers
else -> throw UnsupportedOperationException("requestBody currently only supports JSON body, text body, byte body and File body.")
}
Expand Down
11 changes: 9 additions & 2 deletions ...in-array-integer-enum/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,15 @@ open class ApiClient(val baseUrl: String, val client: Call.Factory = defaultClie
.toRequestBody((mediaType ?: JSON_MEDIA_TYPE).toMediaTypeOrNull())
}
mediaType == XML_MEDIA_TYPE -> throw UnsupportedOperationException("xml not currently supported.")
mediaType == TEXT_MEDIA_TYPE && content is String ->
content.toRequestBody(TEXT_MEDIA_TYPE.toMediaTypeOrNull())
mediaType == TEXT_MEDIA_TYPE -> {
val textualContent = when {
content is CharSequence -> content.toString()
content is Number -> content.toString()
content is Boolean -> content.toString()
else -> throw UnsupportedOperationException("requestBody currently only supports text body containing primitive types: characters, numbers, or booleans.")
}
textualContent.toRequestBody(mediaType.toMediaTypeOrNull())
}
// TODO: this should be extended with other serializers
else -> throw UnsupportedOperationException("requestBody currently only supports JSON body, text body, byte body and File body.")
}
Expand Down
11 changes: 9 additions & 2 deletions ...le-string-jvm-okhttp4/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,15 @@ open class ApiClient(val baseUrl: String, val client: Call.Factory = defaultClie
.toRequestBody((mediaType ?: JSON_MEDIA_TYPE).toMediaTypeOrNull())
}
mediaType == XML_MEDIA_TYPE -> throw UnsupportedOperationException("xml not currently supported.")
mediaType == TEXT_MEDIA_TYPE && content is String ->
content.toRequestBody(TEXT_MEDIA_TYPE.toMediaTypeOrNull())
mediaType == TEXT_MEDIA_TYPE -> {
val textualContent = when {
content is CharSequence -> content.toString()
content is Number -> content.toString()
content is Boolean -> content.toString()
else -> throw UnsupportedOperationException("requestBody currently only supports text body containing primitive types: characters, numbers, or booleans.")
}
textualContent.toRequestBody(mediaType.toMediaTypeOrNull())
}
// TODO: this should be extended with other serializers
else -> throw UnsupportedOperationException("requestBody currently only supports JSON body, text body, byte body and File body.")
}
Expand Down
11 changes: 9 additions & 2 deletions ...cimal-default-okhttp4/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,15 @@ open class ApiClient(val baseUrl: String, val client: Call.Factory = defaultClie
.toRequestBody((mediaType ?: JSON_MEDIA_TYPE).toMediaTypeOrNull())
}
mediaType == XML_MEDIA_TYPE -> throw UnsupportedOperationException("xml not currently supported.")
mediaType == TEXT_MEDIA_TYPE && content is String ->
content.toRequestBody(TEXT_MEDIA_TYPE.toMediaTypeOrNull())
mediaType == TEXT_MEDIA_TYPE -> {
val textualContent = when {
content is CharSequence -> content.toString()
content is Number -> content.toString()
content is Boolean -> content.toString()
else -> throw UnsupportedOperationException("requestBody currently only supports text body containing primitive types: characters, numbers, or booleans.")
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.
Outdated
}
textualContent.toRequestBody(mediaType.toMediaTypeOrNull())
}
// TODO: this should be extended with other serializers
else -> throw UnsupportedOperationException("requestBody currently only supports JSON body, text body, byte body and File body.")
}
Expand Down
11 changes: 9 additions & 2 deletions ...lt-values-jvm-okhttp4/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,15 @@ open class ApiClient(val baseUrl: String, val client: Call.Factory = defaultClie
.toRequestBody((mediaType ?: JSON_MEDIA_TYPE).toMediaTypeOrNull())
}
mediaType == XML_MEDIA_TYPE -> throw UnsupportedOperationException("xml not currently supported.")
mediaType == TEXT_MEDIA_TYPE && content is String ->
content.toRequestBody(TEXT_MEDIA_TYPE.toMediaTypeOrNull())
mediaType == TEXT_MEDIA_TYPE -> {
val textualContent = when {
content is CharSequence -> content.toString()
content is Number -> content.toString()
content is Boolean -> content.toString()
else -> throw UnsupportedOperationException("requestBody currently only supports text body containing primitive types: characters, numbers, or booleans.")
}
textualContent.toRequestBody(mediaType.toMediaTypeOrNull())
}
// TODO: this should be extended with other serializers
else -> throw UnsupportedOperationException("requestBody currently only supports JSON body, text body, byte body and File body.")
}
Expand Down
11 changes: 9 additions & 2 deletions ...in-enum-default-value/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,15 @@ open class ApiClient(val baseUrl: String, val client: Call.Factory = defaultClie
.toRequestBody((mediaType ?: JSON_MEDIA_TYPE).toMediaTypeOrNull())
}
mediaType == XML_MEDIA_TYPE -> throw UnsupportedOperationException("xml not currently supported.")
mediaType == TEXT_MEDIA_TYPE && content is String ->
content.toRequestBody(TEXT_MEDIA_TYPE.toMediaTypeOrNull())
mediaType == TEXT_MEDIA_TYPE -> {
val textualContent = when {
content is CharSequence -> content.toString()
content is Number -> content.toString()
content is Boolean -> content.toString()
else -> throw UnsupportedOperationException("requestBody currently only supports text body containing primitive types: characters, numbers, or booleans.")
}
textualContent.toRequestBody(mediaType.toMediaTypeOrNull())
}
// TODO: this should be extended with other serializers
else -> throw UnsupportedOperationException("requestBody currently only supports JSON body, text body, byte body and File body.")
}
Expand Down
11 changes: 9 additions & 2 deletions ...store/kotlin-explicit/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,15 @@ public open class ApiClient(public val baseUrl: String, public val client: Call.
.toRequestBody((mediaType ?: JSON_MEDIA_TYPE).toMediaTypeOrNull())
}
mediaType == XML_MEDIA_TYPE -> throw UnsupportedOperationException("xml not currently supported.")
mediaType == TEXT_MEDIA_TYPE && content is String ->
content.toRequestBody(TEXT_MEDIA_TYPE.toMediaTypeOrNull())
mediaType == TEXT_MEDIA_TYPE -> {
val textualContent = when {
content is CharSequence -> content.toString()
content is Number -> content.toString()
content is Boolean -> content.toString()
else -> throw UnsupportedOperationException("requestBody currently only supports text body containing primitive types: characters, numbers, or booleans.")
}
textualContent.toRequestBody(mediaType.toMediaTypeOrNull())
}
// TODO: this should be extended with other serializers
else -> throw UnsupportedOperationException("requestBody currently only supports JSON body, text body, byte body and File body.")
}
Expand Down
11 changes: 9 additions & 2 deletions .../petstore/kotlin-gson/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,15 @@ open class ApiClient(val baseUrl: String, val client: Call.Factory = defaultClie
.toRequestBody((mediaType ?: JSON_MEDIA_TYPE).toMediaTypeOrNull())
}
mediaType == XML_MEDIA_TYPE -> throw UnsupportedOperationException("xml not currently supported.")
mediaType == TEXT_MEDIA_TYPE && content is String ->
content.toRequestBody(TEXT_MEDIA_TYPE.toMediaTypeOrNull())
mediaType == TEXT_MEDIA_TYPE -> {
val textualContent = when {
content is CharSequence -> content.toString()
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.
Outdated
content is Number -> content.toString()
content is Boolean -> content.toString()
else -> throw UnsupportedOperationException("requestBody currently only supports text body containing primitive types: characters, numbers, or booleans.")
}
textualContent.toRequestBody(mediaType.toMediaTypeOrNull())
}
// TODO: this should be extended with other serializers
else -> throw UnsupportedOperationException("requestBody currently only supports JSON body, text body, byte body and File body.")
}
Expand Down
11 changes: 9 additions & 2 deletions ...tstore/kotlin-jackson/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,15 @@ open class ApiClient(val baseUrl: String, val client: Call.Factory = defaultClie
.toRequestBody((mediaType ?: JSON_MEDIA_TYPE).toMediaTypeOrNull())
}
mediaType == XML_MEDIA_TYPE -> throw UnsupportedOperationException("xml not currently supported.")
mediaType == TEXT_MEDIA_TYPE && content is String ->
content.toRequestBody(TEXT_MEDIA_TYPE.toMediaTypeOrNull())
mediaType == TEXT_MEDIA_TYPE -> {
val textualContent = when {
content is CharSequence -> content.toString()
content is Number -> content.toString()
content is Boolean -> content.toString()
else -> throw UnsupportedOperationException("requestBody currently only supports text body containing primitive types: characters, numbers, or booleans.")
}
textualContent.toRequestBody(mediaType.toMediaTypeOrNull())
}
// TODO: this should be extended with other serializers
else -> throw UnsupportedOperationException("requestBody currently only supports JSON body, text body, byte body and File body.")
}
Expand Down
Loading
Loading