[Spring] Remove @Nullable annotation for NativeWebRequest in Spring controller

[jpfinne]

Avoid compilation error due to missing import for @Nullable annotation put in Spring controllers

Fixes #23581 (Regression coming from introduction of jspecify)

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package || exit
  ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
  ./bin/utils/export_docs_generators.sh || exit
  

  (For Windows users, please run the script in WSL)
  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
• File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
• If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

---

Summary by cubic

Removed @Nullable from NativeWebRequest in generated Spring controllers to avoid missing org.springframework.lang.Nullable imports with jspecify. Tests now ensure @Nullable is not applied to NativeWebRequest while org.jspecify.annotations.Nullable imports remain where expected.

• Bug Fixes

  • Removed @Nullable from the NativeWebRequest field and constructor param in apiController.mustache.

• Refactors

  • Strengthened tests with precise pattern matching (avoids JsonNullable false positives), new import assertions (doesImportAnnotation/doesNotImportAnnotation supporting short or FQCN), and clearer assertion messages; added checks that org.jspecify.annotations.Nullable is imported in generated files (including Spring Boot controllers) but not used on NativeWebRequest.

^{Written for commit 41a9341. Summary will update on new commits.}

[cubic-dev-ai]

1 issue found across 4 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator/src/test/java/org/openapitools/codegen/java/assertions/TypeAnnotationsAssert.java">

<violation number="1" location="modules/openapi-generator/src/test/java/org/openapitools/codegen/java/assertions/TypeAnnotationsAssert.java:29">
P2: Import-matching regex is not anchored to the final simple name, so `doesImportAnnotation("Nullable")` can pass on unrelated imports like `JsonNullable` and hide regressions.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[jpfinne]

@wing328 This fixes a compilation error. It might be good to include in 7.22

[wing328]

thanks for the fix

please resolve the merge conflicts and i'll try to get it merged before upcoming release.

[jpfinne]

thanks for the fix

please resolve the merge conflicts and i'll try to get it merged before upcoming release.

@wing328 done

[wing328]

cc @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)