[swift6] fix map nullable values (#17996)#23629
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Apr 27, 2026
Merged
Conversation
Swift6 generator ignores `nullable: true` on `additionalProperties` values, producing `[String: String]` instead of `[String: String?]`. This causes `DecodingError` at runtime when the JSON payload contains null values inside dictionaries. Mirrors the fix applied to the Kotlin generator in OpenAPITools#23074.
Member
|
lgtm. thanks for the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Swift 6 client generator ignores
nullable: trueonadditionalPropertiesvalues, producing[String: String]instead of[String: String?]. This causesDecodingErrorat runtime when the JSON payload contains null values inside dictionaries.This is the same bug as #16501 (fixed for kotlin-spring in #23074), now applied to the Swift 6 generator.
Example:
Given this OpenAPI spec:
Before this fix:
After this fix:
PR checklist
master(upcoming7.x.0minor release - breaking changes with fallbacks)Summary by cubic
Fixes Swift 6 generator to honor
nullable: truefor dictionary values, generating[String: String?]instead of[String: String]. Prevents DecodingError when JSON maps contain nulls.[String: T?]foradditionalPropertieswhennullable: true; default andnullable: falsestay non-optional.getItemsTypeDeclarationand updated map handling ingetTypeDeclarationto append?only when needed.[String: String?]vs[String: String]behavior.Written for commit bb3aecf. Summary will update on new commits.