Skip to content

Bugfix/jspecify#23672

Draft
jpfinne wants to merge 5 commits intoOpenAPITools:masterfrom
jpfinne:bugfix/jspecify
Draft

Bugfix/jspecify#23672
jpfinne wants to merge 5 commits intoOpenAPITools:masterfrom
jpfinne:bugfix/jspecify

Conversation

@jpfinne
Copy link
Copy Markdown
Contributor

@jpfinne jpfinne commented May 1, 2026

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Adds JSpecify nullability to generated Spring path params and expands the jspecify spec with a required multipart upload (JSON response) and a binary download endpoint. Regenerates Java jspecify clients and Spring Boot server samples to add downloadIdGet, the UploadPostDefaultResponse model, and updated docs/tests.

  • Bug Fixes

    • Add {{>nullableAnnotation}} to JavaSpring path parameters (@PathVariable) to fix missing nullability in jspecify builds.
  • New Features

    • Spec updates: /upload returns JSON UploadPostDefaultResponse; file is required, optional metadata part; new /download/{id} returns application/octet-stream.
    • Regenerated samples for native-jackson3-jspecify, restclient-springBoot4-jackson3-jspecify, resttemplate-springBoot4-jackson3-jspecify, webclient-springBoot4-jackson3-jspecify, and the Spring Boot server (adds DownloadApi and UploadPostDefaultResponse) with updated endpoints, docs, and tests.

Written for commit 9389540. Summary will update on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant