Fix localized shutdown message#13877
Open
RuleGaed wants to merge 1 commit into
Open
Conversation
| public net.kyori.adventure.text.Component shutdownMessage() { | ||
| String msg = getShutdownMessage(); | ||
| return msg != null ? net.kyori.adventure.text.serializer.legacy.LegacyComponentSerializer.legacySection().deserialize(msg) : null; | ||
| return this.configuration.getRichMessage("settings.shutdown-message"); |
Member
There was a problem hiding this comment.
This is not a rich message
RuleGaed
force-pushed
the
fix-localized-shutdown-message
branch
from
892d1a0 to
16d7174
Compare
Author
|
Fair point, I reverted that part and kept the existing legacy parsing. The PR now only changes the default to null and uses the vanilla translatable shutdown message as the fallback when no custom shutdown message is configured. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11208.
Uses the vanilla translatable shutdown message when no custom shutdown message is configured, while keeping custom shutdown messages configurable via bukkit.yml.