Add support for generating binary data in blob/binary columns#28
Open
adregner wants to merge 3 commits intoPercona-Lab:masterfrom
Open
Add support for generating binary data in blob/binary columns#28adregner wants to merge 3 commits intoPercona-Lab:masterfrom
adregner wants to merge 3 commits intoPercona-Lab:masterfrom
Conversation
percona-csalguero
approved these changes
Sep 23, 2022
Contributor
|
Hi, Sorry for the late review. Could you fix the merge conflicts please? Thanks |
Author
|
Seems support for binary fields was committed to master after this was initially written, although using normal ASCII strings for values. For my use case this patch was written for it was important to actually have non-ASCII data in the generated test tables, so I just did a sort of logical merge where it will append more random binary data to such fields if the field side and the size of the generated "fake" strings allows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These column types were previously getting ASCII text generated for them, and this generates an equivalent amount of random binary data instead.
Tested by pointing the tool at a table with this schema and generating some rows.
the rows