Skip to content

Match host PHP version to Docker (8.2) to fix blackbox tests#200

Merged
LKaemmerling merged 1 commit intoPromPHP:mainfrom
simPod:fix/blackbox-php-version
Mar 19, 2026
Merged

Match host PHP version to Docker (8.2) to fix blackbox tests#200
LKaemmerling merged 1 commit intoPromPHP:mainfrom
simPod:fix/blackbox-php-version

Conversation

@simPod
Copy link
Copy Markdown
Contributor

@simPod simPod commented Mar 19, 2026

Summary

  • composer install on the host (PHP 8.4) pulls doctrine/instantiator 2.x which uses typed constants (PHP 8.3+ syntax)
  • The blackbox tests run inside a PHP 8.2 Docker container, so mocking \Redis triggers a parse error when loading doctrine/instantiator
  • Changed setup-php from 8.4 to 8.2 to match the Docker runtime, so Composer resolves compatible dependencies

@simPod simPod marked this pull request as draft March 19, 2026 07:58
@simPod simPod force-pushed the fix/blackbox-php-version branch 2 times, most recently from b59b0d0 to de1bdb9 Compare March 19, 2026 08:07
@simPod simPod changed the title Bump Docker PHP from 8.2 to 8.4 Pin phpredis to 6.2.0 in Docker to fix blackbox tests Mar 19, 2026
@simPod simPod force-pushed the fix/blackbox-php-version branch from de1bdb9 to 27ba64b Compare March 19, 2026 08:22
@simPod simPod changed the title Pin phpredis to 6.2.0 in Docker to fix blackbox tests Run composer install inside Docker to fix blackbox tests Mar 19, 2026
@simPod simPod force-pushed the fix/blackbox-php-version branch 2 times, most recently from bf3cf0c to 1388a5c Compare March 19, 2026 08:25
composer install on the host (PHP 8.4) pulls doctrine/instantiator 2.x
which uses typed constants (PHP 8.3+ feature). Since the blackbox tests
run inside a PHP 8.2 Docker container, the mock of \Redis triggers a
parse error when loading doctrine/instantiator.

Use PHP 8.2 on the host so Composer resolves dependencies compatible
with the Docker runtime.

Signed-off-by: Simon Podlipsky <simon@podlipsky.net>
@simPod simPod force-pushed the fix/blackbox-php-version branch from 1388a5c to a0e28da Compare March 19, 2026 08:33
@simPod simPod changed the title Run composer install inside Docker to fix blackbox tests Match host PHP version to Docker (8.2) to fix blackbox tests Mar 19, 2026
@simPod simPod marked this pull request as ready for review March 19, 2026 08:36
@simPod simPod requested a review from LKaemmerling March 19, 2026 08:36
@LKaemmerling LKaemmerling merged commit f23fc80 into PromPHP:main Mar 19, 2026
20 checks passed
@LKaemmerling
Copy link
Copy Markdown
Member

Thank you!

@simPod simPod deleted the fix/blackbox-php-version branch March 19, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants