Skip to content

chore(bestpractices): embed URLs inline + resolve SUGGESTED ? placeholders (RAN-52)#98

Merged
aksOps merged 1 commit intomainfrom
chore/ran-52-bestpractices-url-fields
Apr 26, 2026
Merged

chore(bestpractices): embed URLs inline + resolve SUGGESTED ? placeholders (RAN-52)#98
aksOps merged 1 commit intomainfrom
chore/ran-52-bestpractices-url-fields

Conversation

@aksOps
Copy link
Copy Markdown
Contributor

@aksOps aksOps commented Apr 26, 2026

Summary

Addresses the board's 04:35Z autofill diagnosis on RAN-52 — six criterion fields where the bestpractices.dev autofill rejected the existing entries even though <key>_url fields were on disk.

Fix 1 — embed URL inline at the start of <key>_justification (4 MUST + 1 SHOULD)

Belt-and-suspenders against whichever field the autofill parser reads. Keeps the existing <key>_url entries untouched.

  • contribution_requirements_justification (SHOULD)
  • release_notes_justification (MUST) — also adds a CHANGELOG.md cross-reference now that PR #97 shipped it
  • report_archive_justification (MUST)
  • vulnerability_report_process_justification (MUST)

Fix 2 — resolve ? placeholders to honest Unmet (2 SUGGESTED)

Both are SUGGESTED-tier so non-blocking for passing, but the autofill flagged them as missing data. Better to be explicit:

  • dynamic_analysis_status: "Unmet" — no DAST / fuzz pipeline; codeiq is a developer CLI binding serve to localhost. Reconsidered when Java fuzzing (e.g. Jazzer) matures.
  • dynamic_analysis_enable_assertions_status: "Unmet"-ea not force-enabled in CI test invocations.

Total diff: 8 insertions / 8 deletions on a single file. JSON parses clean (151 keys, project_id: 12650, level: "passing").

After this lands

Board re-clicks 🤖 on https://www.bestpractices.dev/projects/12650 → autofill picks up the inline URLs and the explicit Unmet answers → all six flagged criteria settle → expecting tiered_percentage to round up to 100% on the basics tier and badge_levelpassing.

Test plan

  • CI green on chore/ran-52-bestpractices-url-fields
  • After merge + autofill re-run, the six flagged criteria are no longer surfaced as missing on the bestpractices.dev project page
  • badge_level flips in_progresspassing

🤖 Generated with Claude Code

…lders (RAN-52)

Address the board's 04:35Z autofill diagnosis on RAN-52: bestpractices.dev's
autofill flagged four URL-required criteria as "URL is requested but got
text" even though `<key>_url` fields were present, plus two SUGGESTED
criteria sitting at `?` placeholders.

URL-required criteria — embed URL as the first token of `_justification`
(in addition to keeping `<key>_url`, belt-and-suspenders so the autofill
parser finds the URL no matter which field it reads):

- contribution_requirements
- release_notes (also adds CHANGELOG.md cross-reference)
- report_archive
- vulnerability_report_process

SUGGESTED `?` → honest `Unmet` with rationale (non-blocking for `passing`):

- dynamic_analysis — no DAST/fuzz pipeline; codeiq is a developer CLI
  binding `serve` to localhost.
- dynamic_analysis_enable_assertions — `-ea` not force-enabled in CI test
  invocations.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Paperclip <noreply@paperclip.ing>
@aksOps aksOps merged commit 92c6e00 into main Apr 26, 2026
13 checks passed
@aksOps aksOps deleted the chore/ran-52-bestpractices-url-fields branch April 26, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant