chore(sonar): final cleanup — direct undefined check + S3776 bucket#15
Merged
chore(sonar): final cleanup — direct undefined check + S3776 bucket#15
Conversation
After PR #14 merged, four typescript:S7741 smells appeared on main — a side effect of `typeof globalThis.window === "undefined"` (carried over verbatim from the original `typeof window` SSR guards). Now that we go through globalThis, the property access yields undefined safely without typeof, so the typeof is genuinely redundant. Replaced with direct `globalThis.window === undefined` in 4 sites. Also adds a go:S3776 / typescript:S3776 bucket to the bulk-accept workflow. Remaining occurrences are HTTP handlers / tailers / engines where complexity is breadth of cases (auth, decode, validate, dispatch, error) rather than nesting — extracting helpers used once would add indirection without reducing reader load. Accepted as project-wide judgement call rather than per-function. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the loop on the maintainability cleanup.
Test plan
🤖 Generated with Claude Code