Skip to content

fix(ui): extract theme-flash inline script to /theme-flash.js for strict CSP #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aksOps merged 1 commit into from
May 4, 2026
Merged

fix(ui): extract theme-flash inline script to /theme-flash.js for strict CSP #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ui/dist/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,18 @@
<link rel="apple-touch-icon" href="/favicon.svg" />
<link rel="manifest" href="/manifest.webmanifest" />
<title>docsiq — GraphRAG knowledge base</title>
<script type="module" crossorigin src="/assets/index-BYq_8sLj.js"></script>
<!--
Theme-flash guard moved out of an inline <script> so the strict
CSP (script-src 'self', no 'unsafe-inline') accepts it. Vite
copies ui/public/theme-flash.js to /theme-flash.js at build
time. Loaded synchronously here so it executes before the SPA
hydrates and prevents FOUC.
-->
<script src="/theme-flash.js"></script>
<script type="module" crossorigin src="/assets/index-Dtmrigu0.js"></script>
<link rel="modulepreload" crossorigin href="/assets/rolldown-runtime-S-ySWqyJ.js">
<link rel="modulepreload" crossorigin href="/assets/graph-YlRq3euP.js">
<link rel="stylesheet" crossorigin href="/assets/index-DBMDkFdw.css">
<link rel="stylesheet" crossorigin href="/assets/index-BZYFJ-vO.css">
</head>
<body>
<div id="root"></div>
Expand Down
39 changes: 8 additions & 31 deletions ui/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,37 +11,14 @@
<link rel="apple-touch-icon" href="/favicon.svg" />
<link rel="manifest" href="/manifest.webmanifest" />
<title>docsiq — GraphRAG knowledge base</title>
<script>
// Block 5.9 — theme-flash guard. Applies the persisted theme class
// before React hydrates so there is no FOUC on first paint. Must run
// synchronously in <head>. Keep in sync with Zustand persist key
// `docsiq-ui` and the Providers.tsx effect that toggles .dark.
(function () {
try {
var raw = localStorage.getItem("docsiq-ui");
var theme = "system";
if (raw) {
var parsed = JSON.parse(raw);
if (parsed && parsed.state && typeof parsed.state.theme === "string") {
theme = parsed.state.theme;
}
}
var effective = theme;
if (theme === "system") {
effective = window.matchMedia && window.matchMedia("(prefers-color-scheme: dark)").matches
? "dark"
: "light";
}
var root = document.documentElement;
root.dataset.theme = effective;
if (effective === "dark") root.classList.add("dark");
} catch (e) {
// If localStorage is unavailable (privacy mode) we simply let
// React decide after hydration; there is a brief FOUC but no
// crash. Do not log — this runs before any logger is attached.
}
})();
</script>
<!--
Theme-flash guard moved out of an inline <script> so the strict
CSP (script-src 'self', no 'unsafe-inline') accepts it. Vite
copies ui/public/theme-flash.js to /theme-flash.js at build
time. Loaded synchronously here so it executes before the SPA
hydrates and prevents FOUC.
-->
<script src="/theme-flash.js"></script>
</head>
<body>
<div id="root"></div>
Expand Down
32 changes: 32 additions & 0 deletions ui/public/theme-flash.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
// Theme-flash guard. Applies the persisted theme class before React
// hydrates so there is no FOUC on first paint. Runs synchronously
// from <head> via <script src="/theme-flash.js">. Lives in public/
// (not src/) so it is served as a static asset and the strict CSP
// (script-src 'self') accepts it without an inline-script exception.
// Keep in sync with the Zustand persist key `docsiq-ui` and the
// Providers.tsx effect that toggles `.dark`.
(function () {
try {
var raw = localStorage.getItem("docsiq-ui");
var theme = "system";
if (raw) {
var parsed = JSON.parse(raw);
if (parsed && parsed.state && typeof parsed.state.theme === "string") {
theme = parsed.state.theme;
}
}
var effective = theme;
if (theme === "system") {
effective =
window.matchMedia && window.matchMedia("(prefers-color-scheme: dark)").matches
? "dark"
: "light";
}
var root = document.documentElement;
root.dataset.theme = effective;
if (effective === "dark") root.classList.add("dark");
} catch (e) {
// localStorage unavailable (privacy mode) — let React decide
// after hydration; brief FOUC but no crash. Do not log.
}
})();
Loading