fix(security): filepath.IsLocal sanitisers for CodeQL path/command-injection

internal/api/project.go

@@ -76,6 +76,13 @@ func projectMiddleware(cfg *config.Config, registry *project.Registry, next http
 			http.Error(w, "invalid project slug", http.StatusBadRequest)
 			return
 		}
+		// IsValidSlug already rejects anything path-dangerous (enforces
+		// `^[a-z0-9_-]+$`); filepath.IsLocal is a CodeQL-recognised
+		// path-injection sanitiser — belt-and-braces for static analysis.
+		if !filepath.IsLocal(slug) {
+			http.Error(w, "invalid project slug", http.StatusBadRequest)
+			return
+		}
 
 		// Lookup. The registry may be nil in tests that bypass serveCmd —
 		// treat nil as "skip registration, just attach the slug."

internal/notes/history.go

@@ -183,6 +183,14 @@ func autoCommit(notesDir, key, author, subject string, deleted bool) {
 	// Relative path of the note file from notesDir — `git -C` makes this
 	// relative too. We always work with forward slashes inside git args.
 	rel := filepath.ToSlash(filepath.FromSlash(key) + ".md")
+	// filepath.IsLocal is a CodeQL-recognised command/path-injection
+	// sanitiser (caller already validates key via ValidateKey, but this
+	// proves safety to the static analyser).
+	if !filepath.IsLocal(rel) {
+		slog.Warn("note history: non-local rel path, skipping commit",
+			"notesDir", notesDir, "key", key)
+		return
+	}
 
 	if deleted {
 		// `git add -A -- <rel>` records removals as well as
@@ -243,6 +251,9 @@ func History(notesDir, key string, limit int) ([]HistoryEntry, error) {
 	}
 
 	rel := filepath.ToSlash(filepath.FromSlash(key) + ".md")
+	if !filepath.IsLocal(rel) {
+		return nil, fmt.Errorf("invalid key: non-local rel path")
+	}
 
 	// %H=sha, %an=author name, %at=author unix epoch, %s=subject.
 	// Null-byte separator keeps fields unambiguous even with whitespace

internal/notes/notes.go

@@ -88,11 +88,17 @@ func resolvePath(notesDir, key string) (string, error) {
 	if err := ValidateKey(key); err != nil {
 		return "", err
 	}
+	// filepath.IsLocal is CodeQL's recognised path-injection sanitiser;
+	// belt-and-braces on top of ValidateKey's segment checks.
+	rel := filepath.FromSlash(key) + ".md"
+	if !filepath.IsLocal(rel) {
+		return "", fmt.Errorf("%w: non-local relative path", ErrInvalidKey)
+	}
 	cleanBase, err := filepath.Abs(notesDir)
 	if err != nil {
 		return "", fmt.Errorf("resolve notes dir: %w", err)
 	}
-	full := filepath.Join(cleanBase, filepath.FromSlash(key)+".md")
+	full := filepath.Join(cleanBase, rel)
 	cleanFull, err := filepath.Abs(full)
 	if err != nil {
 		return "", fmt.Errorf("resolve note path: %w", err)