fix(ci): exclude screenshots.spec.ts from default playwright run#72
Merged
fix(ci): exclude screenshots.spec.ts from default playwright run#72
Conversation
Block 7's screenshots.spec.ts talks to a live docsiq backend on a fixed port; CI has only the Vite dev server booted, so every screenshot test fails with ERR_CONNECTION_REFUSED. Gate the spec behind PLAYWRIGHT_SCREENSHOTS so the dedicated regeneration script opts in and the default e2e suite ignores it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Block 7's
ui/e2e/screenshots.spec.ts(merged in #69) talks to a live docsiq backend on a fixed port. CI only boots the Vite dev server, so every screenshot test fails with ERR_CONNECTION_REFUSED. This caused PR #71 (Block 5) to show a red `e2e (chromium)` check; it ended up merging because that workflow isn't a required check, but every future UI-touching PR inherits the same red signal.Gate the spec behind a
PLAYWRIGHT_SCREENSHOTSenv var so the dedicated regeneration script opts in and the default e2e suite ignores it.Test plan
🤖 Generated with Claude Code