adding rate limiting middleware#104
Merged
charithaT07 merged 2 commits intomainfrom Feb 3, 2026
Merged
Conversation
clavery
reviewed
Feb 2, 2026
| if (delayMs === undefined) { | ||
| delayMs = computeBackoffDelayMs(startingAttempt, baseDelayMs, maxDelayMs); | ||
| } else { | ||
| delayMs = Math.min(delayMs, maxDelayMs); |
Collaborator
There was a problem hiding this comment.
Math.min here seems to imply we might not always respect Retry-After headers from MRT. I think it's important we do.
Collaborator
Author
There was a problem hiding this comment.
I updated to always respect Retry-After and apply maxDelayMs only when needed
clavery
approved these changes
Feb 3, 2026
Collaborator
clavery
left a comment
clavery
left a comment
There was a problem hiding this comment.
Thanks. Will try to force this to happen in my testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brief description of what this PR does.
This PR improves the SDK’s createRateLimitMiddleware to make rate-limit retries more reliable.
Retries now work even when openapi-fetch does not provide ctx.fetch, by falling back to config.fetch or the global fetch. The retry logic also adds safer backoff behavior, respects abort signals, and handles request cloning more carefully. Tests were updated to cover these changes.
Testing
How was this tested?
pnpm test)pnpm run format)