Add --extra-headers flag and env var support for HTTP requests#52
Merged
Add --extra-headers flag and env var support for HTTP requests#52
Conversation
Add support for custom HTTP headers via --extra-headers flag and SFCC_EXTRA_HEADERS environment variable. This enables CI environments to pass Cloudflare firewall headers via secrets. Changes: - Add headers field to ExtraParamsConfig interface - Update createExtraParamsMiddleware to apply extra headers - Add --extra-headers flag with SFCC_EXTRA_HEADERS env var - Add env vars to existing --extra-query (SFCC_EXTRA_QUERY) and --extra-body (SFCC_EXTRA_BODY) flags - Update E2E workflow to use SFCC_EXTRA_HEADERS secret - Add unit tests for header handling
Collaborator
Author
|
Bypassing review so we can test this with e2e tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--extra-headershidden flag withSFCC_EXTRA_HEADERSenv var support for passing custom HTTP headers to all API requests--extra-query(SFCC_EXTRA_QUERY) and--extra-body(SFCC_EXTRA_BODY) flags for consistencySFCC_EXTRA_HEADERSsecret for Cloudflare firewall bypassThis enables CI environments to pass Cloudflare firewall headers via GitHub secrets.
Usage
Test plan
SFCC_EXTRA_HEADERSsecret ine2e-devenvironment