feat: surface config warnings (hostname mismatch, source errors)#85
Merged
feat: surface config warnings (hostname mismatch, source errors)#85
Conversation
Config sources that encounter errors (e.g., malformed JSON) now: - Re-throw after logging at trace level - Get caught by resolver which creates SOURCE_ERROR warning - Warnings are logged at warn level in CLI This helps users identify configuration problems without blocking execution.
Matches CLI flag name (--server) for clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Config warnings are now surfaced to users instead of being silently swallowed at trace level:
--serverflag differs from dw.json hostname, users see a warning explaining that config file values are being ignored; this applies to all config sources that may supply server values along with credentialsPreviously these warnings were only visible with trace-level logging. Now users can identify configuration problems or "gotchas" without blocking execution.
Thanks to @SGD1953 for the idea!
Changes
SOURCE_ERRORwarningsHOSTNAME_MISMATCHandSOURCE_ERRORTest plan
b2c setup config- should see warning about parse failureb2c code deploy --server different.host.comwith different hostname in dw.json) - should see warning about hostname mismatchcloses #84