Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,15 @@ and subsequently closed after a further 7 days of inactivity.
Open a pull request with the following changes:

1. Bump the
[package version](https://github.com/Shopify/checkout-sheet-kit-react-native/blob/main/modules/%40shopify/checkout-sheet-kit/package.json#L4)
of the `@shopify/checkout-sheet-kit` module.
[package version](https://github.com/Shopify/checkout-kit/blob/main/modules/%40shopify/checkout-kit/package.json#L4)
of the `@shopify/checkout-kit` module.
2. Add an entry to the top of the [CHANGELOG](../CHANGELOG.md)

Once you have merged a pull request with these changes, you will be ready to
publish a new version.

To do so, navigate to
<https://github.com/Shopify/checkout-sheet-kit-react-native/releases> and click
<https://github.com/Shopify/checkout-kit/releases> and click
"Draft a new release" then complete the following steps:

1. Create a tag for the new version
Expand All @@ -66,5 +66,5 @@ To do so, navigate to
pull requests where applicable, in the description box.
4. Check "Set as the latest release".
5. When ready, click "Publish release". This will kickstart the
[CI process](https://github.com/Shopify/checkout-sheet-kit-react-native/actions/workflows/publish.yml)
[CI process](https://github.com/Shopify/checkout-kit/actions/workflows/publish.yml)
to publish a new version of the NPM package.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ body:

- type: input
attributes:
label: What version of `@shopify/checkout-sheet-kit` are you using?
label: What version of `@shopify/checkout-kit` are you using?
description:
Please list the package version and device you are testing with.
validations:
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/install-cocoapods/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ runs:
with:
path: |
sample/ios/Pods
key: ${{ runner.os }}-cocoapods-${{ hashFiles('sample/ios/Podfile.lock', 'sample/Gemfile.lock', 'sample/Gemfile', 'package.json', 'sample/package.json', 'modules/@shopify/checkout-sheet-kit/package.json', 'pnpm-lock.yaml') }}
key: ${{ runner.os }}-cocoapods-${{ hashFiles('sample/ios/Podfile.lock', 'sample/Gemfile.lock', 'sample/Gemfile', 'package.json', 'sample/package.json', 'modules/@shopify/checkout-kit/package.json', 'pnpm-lock.yaml') }}

- name: Install cocoapods
shell: bash
Expand Down
6 changes: 3 additions & 3 deletions .github/dependabot.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ updates:
- "version-update:semver-major"
- "version-update:semver-minor"

# Checkout Sheet Kit module dependencies
# Checkout Kit module dependencies
- package-ecosystem: npm
directory: "/modules/@shopify/checkout-sheet-kit"
directory: "/modules/@shopify/checkout-kit"
schedule:
interval: daily
cooldown:
Expand Down Expand Up @@ -73,7 +73,7 @@ updates:

# Android dependencies (Gradle) - Module
- package-ecosystem: gradle
directory: "/modules/@shopify/checkout-sheet-kit/android"
directory: "/modules/@shopify/checkout-kit/android"
schedule:
interval: daily
cooldown:
Expand Down
10 changes: 5 additions & 5 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@
> [!IMPORTANT]
>
> - [ ] I've added tests to support my implementation
> - [ ] I have read and agree with the [Contribution Guidelines](https://github.com/shopify/checkout-sheet-kit-react-native/blob/main/.github/CONTRIBUTING.md).
> - [ ] I have read and agree with the [Code of Conduct](https://github.com/shopify/checkout-sheet-kit-react-native/blob/main/.github/CODE_OF_CONDUCT.md).
> - [ ] I've updated the [README](https://github.com/shopify/checkout-sheet-kit-react-native).
> - [ ] I have read and agree with the [Contribution Guidelines](https://github.com/Shopify/checkout-kit/blob/main/.github/CONTRIBUTING.md).
> - [ ] I have read and agree with the [Code of Conduct](https://github.com/Shopify/checkout-kit/blob/main/.github/CODE_OF_CONDUCT.md).
> - [ ] I've updated the [README](https://github.com/Shopify/checkout-kit).
>
> _Releasing a new version of the kit?_
>
> - [ ] I have bumped the version number in the [`package.json` file](https://github.com/Shopify/checkout-sheet-kit-react-native/blob/main/modules/%40shopify/checkout-sheet-kit/package.json#L4).
> - [ ] I have bumped the version number in the [`package.json` file](https://github.com/Shopify/checkout-kit/blob/main/modules/%40shopify/checkout-kit/package.json#L4).

---

> [!TIP]
> See the [Contributing documentation](https://github.com/shopify/checkout-sheet-kit-react-native/blob/main/.github/CONTRIBUTING.md#releasing-a-new-version) for instructions on how to publish a new version of the library.
> See the [Contributing documentation](https://github.com/Shopify/checkout-kit/blob/main/.github/CONTRIBUTING.md#releasing-a-new-version) for instructions on how to publish a new version of the library.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:

- run:
pnpm test --coverage
--testPathPatterns="modules/@shopify/checkout-sheet-kit/tests"
--testPathPatterns="modules/@shopify/checkout-kit/tests"
--coverageReporters=json-summary

- name: Coverage comment
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deprecate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Deprecate
run: |
echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > .npmrc
npm deprecate @shopify/checkout-sheet-kit@"${{ env.VERSIONS }}" "This version is deprecated. Please upgrade to the latest version of @shopify/checkout-sheet-kit."
npm deprecate @shopify/checkout-sheet-kit@"${{ env.VERSIONS }}" "This version is deprecated. Please upgrade to @shopify/checkout-kit."
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
VERSIONS: '< 2.0.1'
6 changes: 3 additions & 3 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
id: npm-tag
run: |
# Read the version from package.json
VERSION=$(node -p "require('./modules/@shopify/checkout-sheet-kit/package.json').version")
VERSION=$(node -p "require('./modules/@shopify/checkout-kit/package.json').version")

# Check if it's a "beta" or "rc" version
if [[ "$VERSION" == *"-beta"* ]] || [[ "$VERSION" == *"-rc"* ]]; then
Expand All @@ -37,10 +37,10 @@ jobs:

- name: Prepare release
run: |
cp README.md modules/@shopify/checkout-sheet-kit
cp README.md modules/@shopify/checkout-kit
pnpm module clean
pnpm module build
cd modules/@shopify/checkout-sheet-kit
cd modules/@shopify/checkout-kit
npm publish --access public --tag ${{ steps.npm-tag.outputs.tag }}
env:
NPM_TOKEN: '' # Empty string forces OIDC
8 changes: 4 additions & 4 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,10 @@ dist
.turbo

# Module
modules/@shopify/checkout-sheet-kit/android/gradle/wrapper/gradle-wrapper.jar
modules/@shopify/checkout-sheet-kit/android/gradle/wrapper/gradle-wrapper.properties
modules/@shopify/checkout-sheet-kit/android/gradlew
modules/@shopify/checkout-sheet-kit/android/gradlew.bat
modules/@shopify/checkout-kit/android/gradle/wrapper/gradle-wrapper.jar
modules/@shopify/checkout-kit/android/gradle/wrapper/gradle-wrapper.properties
modules/@shopify/checkout-kit/android/gradlew
modules/@shopify/checkout-kit/android/gradlew.bat

# Sample bundle
**/index.android.bundle
Expand Down
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ see [guidelines and instructions](.github/CONTRIBUTING.md).

This repo is subdivided into 3 parts using pnpm workspaces:

- The base repo (workspace name = `checkout-sheet-kit-react-native`)
- The `@shopify/checkout-sheet-kit` Native Module (workspace name = `module`)
- The base repo (workspace name = `checkout-kit-react-native`)
- The `@shopify/checkout-kit` Native Module (workspace name = `module`)
- The sample application (workspace name = `sample`)

Each of the workspaces contains a separate `package.json` to manage tasks
Expand Down Expand Up @@ -75,7 +75,7 @@ SCCACHE=false pnpm sample android
## Making changes to the Native Module

If your intentions are to modify the TS code for the Native Module under
`modules/@shopify/checkout-sheet-kit`, note that you will not need to rebuild to
`modules/@shopify/checkout-kit`, note that you will not need to rebuild to
observe your changes in the sample app. This is because the sample app is
importing the TS files directly from the module directory (through symlinking).

Expand Down Expand Up @@ -118,7 +118,7 @@ There are 3 types of tests in this repo: Typescript, Swift and Java - each for
testing the Native Module.

```sh
# Run Jest tests for "modules/@shopify/checkout-sheet-kit/src/**/*.tsx"
# Run Jest tests for "modules/@shopify/checkout-kit/src/**/*.tsx"
pnpm test

# Run swift tests for the Native Module
Expand Down
Loading
Loading