Skip to content

[Security] Sanitize Cookie headers in debug logs#7508

Draft
gonzaloriestra wants to merge 1 commit intomainfrom
security-sanitize-cookie-headers-10005827685003157313
Draft

[Security] Sanitize Cookie headers in debug logs#7508
gonzaloriestra wants to merge 1 commit intomainfrom
security-sanitize-cookie-headers-10005827685003157313

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Sensitive session data from Cookie and Set-Cookie headers can currently be leaked in debug logs when network request info is printed. This poses a security risk if logs are shared or stored insecurely.

WHAT is this pull request doing?

This PR adds 'cookie' to the list of keywords in sanitizedHeadersOutput. This ensures that any header containing "cookie" (case-insensitive) is redacted from the debug output.

How to test your changes?

Run any command that performs a network request with cookies and check the debug logs. The Cookie and Set-Cookie headers should no longer appear in the "With request headers:" section of the output.

Duplicate check

I ran git log --grep="Security" --oneline -n 200 and git log --grep="Jules" --oneline -n 200 as a fallback since gh was unavailable. I found no previous PRs addressing this specific header sanitization.
Closest PR considered:

  • 3a92d0375 Merge pull request #7481 from Shopify/fix/theme-push-fresh-dynamic-source-defaults: Touched the same file for theme-related fixes, but did not address security sanitization of headers.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact

PR created automatically by Jules for task 10005827685003157313 started by @gonzaloriestra

Adds 'cookie' to the list of keywords to be sanitized in debug logs
to prevent sensitive session data leakage. Includes unit tests
to verify the sanitization of Cookie and Set-Cookie headers.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant