[Security] Sanitize Cookie headers in debug logs#7508
[Security] Sanitize Cookie headers in debug logs#7508gonzaloriestra wants to merge 1 commit intomainfrom
Conversation
Adds 'cookie' to the list of keywords to be sanitized in debug logs to prevent sensitive session data leakage. Includes unit tests to verify the sanitization of Cookie and Set-Cookie headers.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
Sensitive session data from
CookieandSet-Cookieheaders can currently be leaked in debug logs when network request info is printed. This poses a security risk if logs are shared or stored insecurely.WHAT is this pull request doing?
This PR adds
'cookie'to the list of keywords insanitizedHeadersOutput. This ensures that any header containing "cookie" (case-insensitive) is redacted from the debug output.How to test your changes?
Run any command that performs a network request with cookies and check the debug logs. The
CookieandSet-Cookieheaders should no longer appear in the "With request headers:" section of the output.Duplicate check
I ran
git log --grep="Security" --oneline -n 200andgit log --grep="Jules" --oneline -n 200as a fallback sinceghwas unavailable. I found no previous PRs addressing this specific header sanitization.Closest PR considered:
3a92d0375 Merge pull request #7481 from Shopify/fix/theme-push-fresh-dynamic-source-defaults: Touched the same file for theme-related fixes, but did not address security sanitization of headers.Checklist
PR created automatically by Jules for task 10005827685003157313 started by @gonzaloriestra