Skip to content

Create pull_request_template.md and Add Contribution Guidelines and License Section in README#13070

Closed
dimpal-yadav wants to merge 3 commits intoTheAlgorithms:masterfrom
dimpal-yadav:master
Closed

Create pull_request_template.md and Add Contribution Guidelines and License Section in README#13070
dimpal-yadav wants to merge 3 commits intoTheAlgorithms:masterfrom
dimpal-yadav:master

Conversation

@dimpal-yadav
Copy link
Copy Markdown

@dimpal-yadav dimpal-yadav commented Oct 1, 2025

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • [ x] Documentation change?

Checklist:

  • [ x] I have read CONTRIBUTING.md.
  • [x ] This pull request is all my own work -- I have not plagiarized.
  • [x ] I know that pull requests will not be merged if they fail the automated tests.
  • [] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [] All new Python files are placed inside an existing directory.
  • [] All filenames are in all lowercase characters with no spaces or dashes.
  • [ ]All functions and variable names follow Python naming conventions.
  • [] All function parameters and return values are annotated with Python type hints.
  • [] All functions have doctests that pass the automated testing.
  • [] All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • [x ] If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes Add Pull Request (PR) Template #13031

@dimpal-yadav dimpal-yadav requested a review from cclauss as a code owner October 1, 2025 20:47
@algorithms-keeper algorithms-keeper Bot added documentation This PR modified documentation files awaiting reviews This PR is ready to be reviewed labels Oct 1, 2025
@dimpal-yadav
Copy link
Copy Markdown
Author

Describe your change:
Add an algorithm?
Fix a bug or typo in an existing algorithm?
Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
[ x] Documentation change?

Checklist:
[ x] I have read CONTRIBUTING.md.
[x ] This pull request is all my own work -- I have not plagiarized.
[x ] I know that pull requests will not be merged if they fail the automated tests.
[] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
[] All new Python files are placed inside an existing directory.
[] All filenames are in all lowercase characters with no spaces or dashes.
[ ]All functions and variable names follow Python naming conventions.
[] All function parameters and return values are annotated with Python type hints.
[] All functions have doctests that pass the automated testing.
[] All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
[x ] If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #13030

@dimpal-yadav
Update README.md

@dimpal-yadav dimpal-yadav changed the title Create pull_request_template.md Create pull_request_template.md and Add Contribution Guidelines and License Section in README Oct 1, 2025
@cclauss
Copy link
Copy Markdown
Member

cclauss commented Oct 1, 2025

https://github.com/TheAlgorithms/Python/blob/master/.github/pull_request_template.md already exists.
https://github.com/TheAlgorithms/Python/blob/master/CONTRIBUTING.md already exists.

The space in the filepath after /.github makes the first file invalid.

Please contribute to a different repo that does not care about attention to detail.

@cclauss cclauss closed this Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed documentation This PR modified documentation files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Pull Request (PR) Template

2 participants