Kadane's Algorithm#13108
Kadane's Algorithm#13108Mayank-Creater wants to merge 9 commits intoTheAlgorithms:masterfrom Mayank-Creater:master
Conversation
algorithms-keeper
Bot
added
require tests
![algorithms-keeper[bot]](https://avatars.gh.lumenfield.work/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,15 @@ | |||
| def maxSubarraySum(arr): | |||
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/arrays/maximum_subarray_sum.py, please provide doctest for the function maxSubarraySum
Please provide return type hint for the function: maxSubarraySum. If the function does not return a value, please provide the type hint as: def function() -> None:
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: maxSubarraySum
Please provide type hint for the parameter: arr
| ans = arr[0] | ||
|
|
||
| for i in range(len(arr)): | ||
| currentSum = 0 |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: currentSum
| currentSum = 0 | ||
|
|
||
| for j in range(i, len(arr)): | ||
| currentSum = currentSum + arr[j] |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: currentSum
for more information, see https://pre-commit.ci
algorithms-keeper
Bot
removed
require tests
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,27 @@ | |||
| def maxSubarraySum(arr: list[int) -> int: | |||
There was a problem hiding this comment.
An error occurred while parsing the file: data_structures/arrays/maximum_subarray_sum.py
Traceback (most recent call last):
File "/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line 146, in parse
reports = lint_file(
^^^^^^^^^^
libcst._exceptions.ParserSyntaxError: Syntax Error @ 1:1.
tokenizer error: Closing parenthesis ')' does not match opening parenthesis '['
def maxSubarraySum(arr: list[int) -> int:
^
algorithms-keeper
Bot
added
the
require tests
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,27 @@ | |||
| def maxSubarraySum(arr: list[int]) -> int: | |||
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/arrays/maximum_subarray_sum.py, please provide doctest for the function maxSubarraySum
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: maxSubarraySum
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,28 @@ | |||
| def max_subarray_sum(arr: list[int]) -> int: | |||
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/arrays/maximum_subarray_sum.py, please provide doctest for the function max_subarray_sum
algorithms-keeper
Bot
removed
the
require tests
for more information, see https://pre-commit.ci
1 participant
Describe your change:
Checklist: