Fix: Corrected Type Hints in sum_of_geometric_progression to Accept Floats.#13145
Closed
Akhila21-6 wants to merge 3 commits intoTheAlgorithms:masterfrom
Closed
Fix: Corrected Type Hints in sum_of_geometric_progression to Accept Floats.#13145Akhila21-6 wants to merge 3 commits intoTheAlgorithms:masterfrom
Akhila21-6 wants to merge 3 commits intoTheAlgorithms:masterfrom
Conversation
…puts and added doctest
…at] to float to resolve Ruff/PYI041 errors
dc8206e to
297788e
Compare
for more information, see https://pre-commit.ci
Member
|
Closing tests_are_failing PRs to prepare for Hacktoberfest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…puts and added doctest
Describe your change:
This PR corrects the type hints for the first_term and common_ratio from int to Union[int, float], as geometric progressions mathematically support float inputs.
Checklist: