Feature/vini antunes/first law of thermodynamics#13266
Feature/vini antunes/first law of thermodynamics#13266ViniViniAntunes wants to merge 24 commits intoTheAlgorithms:masterfrom ViniViniAntunes:feature/ViniAntunes/first_law_of_thermodynamics
Conversation
Add magnetic_flux.py
…gnetic_flux_implementation Create magnetic_flux.py
for more information, see https://pre-commit.ci
Fix the test string mode
Fix test mode string
Fitting to ruff.yml
…gnetic_flux_implementation Feature/vini antunes/add magnetic flux implementation
for more information, see https://pre-commit.ci
Round output
…gnetic_flux_implementation Update magnetic_flux.py
Fixing testmod string
…gnetic_flux_implementation Update magnetic_flux.py
algorithms-keeper
Bot
added
the
require tests
![algorithms-keeper[bot]](https://avatars.gh.lumenfield.work/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
|
|
||
|
|
||
| def check_args(argument: float) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file physics/first_law_of_thermodynamics.py, please provide doctest for the function check_args
| raise TypeError("Invalid argument. Should be an integer or float.") | ||
|
|
||
|
|
||
| def categorize_system(argument_value: float, argument_name: str) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file physics/first_law_of_thermodynamics.py, please provide doctest for the function categorize_system
| from math import cos, radians | ||
|
|
||
|
|
||
| def check_args(magnetic_field: float, area: float, angle: float) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file physics/magnetic_flux.py, please provide doctest for the function check_args
for more information, see https://pre-commit.ci
algorithms-keeper
Bot
added
tests are failing
…ps://github.com/ViniViniAntunes/Python into feature/ViniAntunes/first_law_of_thermodynamics
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
|
|
||
|
|
||
| def __check_args(argument: float) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file physics/first_law_of_thermodynamics.py, please provide doctest for the function __check_args
| raise TypeError("Invalid argument. Should be an integer or float.") | ||
|
|
||
|
|
||
| def __categorize_system(argument_value: float, argument_name: str) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file physics/first_law_of_thermodynamics.py, please provide doctest for the function __categorize_system
| from math import cos, radians | ||
|
|
||
|
|
||
| def check_args(magnetic_field: float, area: float, angle: float) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file physics/magnetic_flux.py, please provide doctest for the function check_args
for more information, see https://pre-commit.ci
algorithms-keeper
Bot
added
tests are failing
…ps://github.com/ViniViniAntunes/Python into feature/ViniAntunes/first_law_of_thermodynamics
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| from math import cos, radians | ||
|
|
||
|
|
||
| def check_args(magnetic_field: float, area: float, angle: float) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file physics/magnetic_flux.py, please provide doctest for the function check_args
for more information, see https://pre-commit.ci
…ps://github.com/ViniViniAntunes/Python into feature/ViniAntunes/first_law_of_thermodynamics
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| from math import cos, radians | ||
|
|
||
|
|
||
| def check_args(magnetic_field: float, area: float, angle: float) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file physics/magnetic_flux.py, please provide doctest for the function check_args
2 participants
Describe your change:
Checklist: