-
-
Notifications
You must be signed in to change notification settings - Fork 50.5k
Add generalized nCr (combinations) calculator for real n and integer r #13623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Naman-Vasudev
wants to merge
5
commits into
TheAlgorithms:master
Choose a base branch
from
Naman-Vasudev:ncr_final
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+77
−0
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4f457c5
Create ncr_combinations.py
Naman-Vasudev 725abb4
Update ncr_combinations.py
Naman-Vasudev ab5dfe3
Update ncr_combinations.py
Naman-Vasudev c15888a
Update ncr_combinations.py
Naman-Vasudev 16cab8c
Update ncr_combinations.py
Naman-Vasudev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| """ | ||
| Generalized nCr (combinations) calculator for real numbers n and integer r. | ||
| Wikipedia URL: https://en.wikipedia.org/wiki/Binomial_coefficient | ||
| """ | ||
|
|
||
| from math import factorial as math_factorial | ||
|
|
||
|
|
||
| def nCr(n: float, r: int) -> float: | ||
| """ | ||
| Compute the number of combinations (n choose r) for real n and integer r | ||
| using the formula: | ||
|
|
||
| nCr = n * (n-1) * (n-2) * ... * (n-r+1) / r! | ||
|
|
||
| Parameters | ||
| ---------- | ||
| n : float | ||
| Total number of items. Can be any real number. | ||
| r : int | ||
| Number of items to choose. Must be a non-negative integer. | ||
|
|
||
| Returns | ||
| ------- | ||
| float | ||
| The number of combinations. | ||
|
|
||
| Raises | ||
| ------ | ||
| ValueError | ||
| If r is not an integer or r < 0 | ||
|
|
||
| Examples | ||
| -------- | ||
| >>> nCr(5, 2) | ||
| 10.0 | ||
| >>> nCr(5.5, 2) | ||
| 12.375 | ||
| >>> nCr(10, 0) | ||
| 1.0 | ||
| >>> nCr(0, 0) | ||
| 1.0 | ||
| >>> nCr(5, -1) | ||
| Traceback (most recent call last): | ||
| ... | ||
| ValueError: r must be a non-negative integer | ||
| >>> nCr(5, 2.5) | ||
| Traceback (most recent call last): | ||
| ... | ||
| ValueError: r must be a non-negative integer | ||
| """ | ||
| if not isinstance(r, int) or r < 0: | ||
| raise ValueError("r must be a non-negative integer") | ||
|
|
||
| if r == 0: | ||
| return 1.0 | ||
|
|
||
| numerator = 1.0 | ||
| for i in range(r): | ||
| numerator *= n - i | ||
|
|
||
| denominator = math_factorial(r) | ||
| return numerator / denominator | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| import doctest | ||
|
|
||
| doctest.testmod() | ||
|
|
||
| # Example usage | ||
| n = float(input("Enter n (real number): ").strip() or 0) | ||
| r = int(input("Enter r (integer): ").strip() or 0) | ||
| print(f"nCr({n}, {r}) = {nCr(n, r)}") | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable and function names should follow the
snake_casenaming convention. Please update the following name accordingly:nCrPlease provide descriptive name for the parameter:
nPlease provide descriptive name for the parameter:
r