refactor: add type hints to maths/softmax.py#14153
Open
N9sha18 wants to merge 1 commit intoTheAlgorithms:masterfrom
Open
refactor: add type hints to maths/softmax.py#14153N9sha18 wants to merge 1 commit intoTheAlgorithms:masterfrom
N9sha18 wants to merge 1 commit intoTheAlgorithms:masterfrom
Conversation
poyea
force-pushed
the
type-hint-cleanup
branch
from
3207df5 to
f76d44d
Compare
poyea
approved these changes
Jan 25, 2026
algorithms-keeper
Bot
removed
the
awaiting reviews
Contributor
There was a problem hiding this comment.
Pull request overview
Adds modern Python type hints to maths/softmax.py to improve readability and align the function signature with current typing style.
Changes:
- Annotated
softmax()input and return types using PEP 604 unions. - Cleaned up docstring formatting and doctest inputs for consistency.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added modern type hints (np.ndarray | list | tuple) to the softmax function to improve code readability and compliance with current Python standards. Verified with doctest (4 passed)