ACNA-3275 point app plugin to deploy service#852
Merged
amulyakashyap09 merged 17 commits intomasterfrom Mar 26, 2025
Merged
Conversation
…a-3275-point-app-plugin-to-deploy-service
Contributor
Author
|
Please do not merge this PR. Before merging :
|
Member
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #852 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 58 59 +1
Lines 3353 3389 +36
Branches 649 663 +14
=========================================
+ Hits 3353 3389 +36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shazron
requested changes
Mar 6, 2025
shazron
requested changes
Mar 6, 2025
added 2 commits
March 10, 2025 19:06
…a-3275-point-app-plugin-to-deploy-service
….com:adobe/aio-cli-plugin-app into acna-3275-point-app-plugin-to-deploy-service
Member
|
This needs adobe/aio-lib-runtime#206 to be merged AND released, make sure the description reflects. Not ready for review until so, and tested again |
shazron
requested changes
Mar 19, 2025
Member
There was a problem hiding this comment.
- needs adobe/aio-lib-runtime#206 to be merged and released before this is merged, add to description
- affirm that testing this works with the dev deployservice (via the apihost env var)
Contributor
Author
|
shazron
approved these changes
Mar 21, 2025
sandeep-paliwal
approved these changes
Mar 25, 2025
… url needs to be in place
purplecabbage
pushed a commit
that referenced
this pull request
Nov 10, 2025
* wip: use ims token to auth runtime deploy actions * default values set * added test cases * fix: missed process env value * Updated code as per comments on PR * Updated code as per comments on PR * Updated code as per comments on PR * Updated code as per comments on PR * feat: ACNA-3602 - Added the Feature Flag for Deploy Service * Updated lib-runtime-dependency * fixed default runtime url * Fixed a scenario, where user does config api host and default runtime url needs to be in place --------- Co-authored-by: Michael Goberling <mgoberling@adobe.com> Co-authored-by: Amulya Kashyap <amulyak@adobe.com> Co-authored-by: Shazron Abdullah <36107+shazron@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
NODE_DEBUG=needle aio app deployto verify headers)NOTE
NODE_DEBUG=needle aio app deployto verify headers)Related Issue
ACNA-3275
ACNA-3602
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Feature Flag Enabled: Should give 200 with IS_DEPLOY_SERVICE_ENABLED = true
Feature Flag Disabled: Should give 401 with IS_DEPLOY_SERVICE_ENABLED = false [as ow auth_handler will not be available]
Types of changes
Checklist: