Skip to content

ACNA-3275 point app plugin to deploy service#852

Merged
amulyakashyap09 merged 17 commits intomasterfrom
acna-3275-point-app-plugin-to-deploy-service
Mar 26, 2025
Merged

ACNA-3275 point app plugin to deploy service#852
amulyakashyap09 merged 17 commits intomasterfrom
acna-3275-point-app-plugin-to-deploy-service

Conversation

@amulyakashyap09
Copy link
Copy Markdown
Contributor

@amulyakashyap09 amulyakashyap09 commented Feb 19, 2025

Description

  • Updated the app plugin to set apihost and auth_handler for the openwhisk client library
  • Added Feature Flags - process.env.IS_DEPLOY_SERVICE_ENABLED [SS attached]
  • PR is tested locally (use NODE_DEBUG=needle aio app deploy to verify headers)
  • feat: ACNA-3659 | Add auth_handler to OW aio-lib-runtime#206 is merged and release
  • Updated the package.json with latest version [aio-lib-runtime updated] and Tested locally for deploy and undeploy scenario again Test Result

NOTE

⚠️ DO NOT MERGE THE PR UNLESS:

  • PROD Deploy Service URL is replaced
  • Tested again (use NODE_DEBUG=needle aio app deploy to verify headers)

Related Issue

ACNA-3275
ACNA-3602

Motivation and Context

How Has This Been Tested?

  • Added unit test cases
  • Locally manually Tested

Screenshots (if appropriate):

Feature Flag Enabled: Should give 200 with IS_DEPLOY_SERVICE_ENABLED = true

Screenshot 2025-03-19 at 17 37 06

Feature Flag Disabled: Should give 401 with IS_DEPLOY_SERVICE_ENABLED = false [as ow auth_handler will not be available]

Screenshot 2025-03-19 at 17 43 08

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@amulyakashyap09
Copy link
Copy Markdown
Contributor Author

Please do not merge this PR.

Before merging :

  • Update the production deploy url
  • And test again.

@shazron
Copy link
Copy Markdown
Member

shazron commented Feb 19, 2025

Please do not merge this PR.

Before merging :

  • Update the production deploy url
  • And test again.
  • put it in the description please
  • the title should have the proper Jira Id in the proper case, with a hyphen ACNA-3275

@amulyakashyap09 amulyakashyap09 changed the title Acna 3275 point app plugin to deploy service ACNA-3275 point app plugin to deploy service Feb 19, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8d7f1ee) to head (69d131d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #852   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           58        59    +1     
  Lines         3353      3389   +36     
  Branches       649       663   +14     
=========================================
+ Hits          3353      3389   +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/lib/auth-helper.js Outdated
Comment thread src/lib/auth-helper.js Outdated
Comment thread src/lib/auth-helper.js Outdated
@amulyakashyap09 amulyakashyap09 requested a review from shazron March 10, 2025 13:35
Amulya Kashyap added 2 commits March 10, 2025 19:06
….com:adobe/aio-cli-plugin-app into acna-3275-point-app-plugin-to-deploy-service
@shazron
Copy link
Copy Markdown
Member

shazron commented Mar 11, 2025

This needs adobe/aio-lib-runtime#206 to be merged AND released, make sure the description reflects. Not ready for review until so, and tested again

Copy link
Copy Markdown
Member

@shazron shazron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • needs adobe/aio-lib-runtime#206 to be merged and released before this is merged, add to description
  • affirm that testing this works with the dev deployservice (via the apihost env var)

Comment thread src/commands/app/deploy.js Outdated
Comment thread src/commands/app/undeploy.js
@amulyakashyap09 amulyakashyap09 requested a review from shazron March 19, 2025 12:12
@amulyakashyap09
Copy link
Copy Markdown
Contributor Author

Screenshot
Screenshot 2025-03-21 at 11 34 20

@amulyakashyap09 amulyakashyap09 merged commit 0c08360 into master Mar 26, 2025
10 checks passed
@shazron shazron deleted the acna-3275-point-app-plugin-to-deploy-service branch May 22, 2025 16:09
purplecabbage pushed a commit that referenced this pull request Nov 10, 2025
* wip: use ims token to auth runtime deploy actions

* default values set

* added test cases

* fix: missed process env value

* Updated code as per comments on PR

* Updated code as per comments on PR

* Updated code as per comments on PR

* Updated code as per comments on PR

* feat: ACNA-3602 - Added the Feature Flag for Deploy Service

* Updated lib-runtime-dependency

* fixed default runtime url

* Fixed a scenario, where user does config api host and default runtime url needs to be in place

---------

Co-authored-by: Michael Goberling <mgoberling@adobe.com>
Co-authored-by: Amulya Kashyap <amulyak@adobe.com>
Co-authored-by: Shazron Abdullah <36107+shazron@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants