Skip to content

clean-build becomes just clean#862

Merged
purplecabbage merged 2 commits intomasterfrom
CleanClean
May 6, 2025
Merged

clean-build becomes just clean#862
purplecabbage merged 2 commits intomasterfrom
CleanClean

Conversation

@purplecabbage
Copy link
Copy Markdown
Member

@purplecabbage purplecabbage commented May 6, 2025

Description

This pull request renames the command from CleanBuild to Clean to simplify the terminology.

Renames the command class and references in the source and test files.
Updates descriptions and exports accordingly.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@purplecabbage purplecabbage requested a review from Copilot May 6, 2025 20:01
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/commands/app/clean.test.js Updated require statements and test descriptions to match the new name.
src/commands/app/clean.js Renamed the command class and exports from CleanBuild to Clean, with updated description attribute.
Comments suppressed due to low confidence (1)

src/commands/app/clean.js:19

  • The logger name still uses 'clean-build' despite the command being renamed to 'Clean'. Consider updating it to '@adobe/aio-cli-plugin-app:clean' for consistency.
const aioLogger = require('@adobe/aio-lib-core-logging')('@adobe/aio-cli-plugin-app:clean-build', { provider: 'debug' })

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0a706ba) to head (f333f19).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #862   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3222      3222           
  Branches       632       632           
=========================================
  Hits          3222      3222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@purplecabbage purplecabbage requested a review from Copilot May 6, 2025 20:05
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the command naming by renaming "CleanBuild" to "Clean" across the source and test files.

  • Renamed require paths, class names, and description strings from "CleanBuild" to "Clean".
  • Updated references in tests, logging labels, and module exports to reflect the new name.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/commands/app/clean.test.js Updated require statement, describe string, and instantiation to use "Clean"
src/commands/app/clean.js Renamed class, updated logging identifier, description, flags, and export to "Clean"

Copy link
Copy Markdown
Contributor

@dthampy dthampy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Sorry that you had to the extra work

@purplecabbage purplecabbage merged commit f39e93c into master May 6, 2025
10 checks passed
@purplecabbage purplecabbage deleted the CleanClean branch May 6, 2025 21:36
purplecabbage added a commit that referenced this pull request Nov 10, 2025
* clean-build becomes just clean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants