clean-build becomes just clean#862
Merged
purplecabbage merged 2 commits intomasterfrom May 6, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/commands/app/clean.test.js | Updated require statements and test descriptions to match the new name. |
| src/commands/app/clean.js | Renamed the command class and exports from CleanBuild to Clean, with updated description attribute. |
Comments suppressed due to low confidence (1)
src/commands/app/clean.js:19
- The logger name still uses 'clean-build' despite the command being renamed to 'Clean'. Consider updating it to '@adobe/aio-cli-plugin-app:clean' for consistency.
const aioLogger = require('@adobe/aio-lib-core-logging')('@adobe/aio-cli-plugin-app:clean-build', { provider: 'debug' })
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #862 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 57 57
Lines 3222 3222
Branches 632 632
=========================================
Hits 3222 3222 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the command naming by renaming "CleanBuild" to "Clean" across the source and test files.
- Renamed require paths, class names, and description strings from "CleanBuild" to "Clean".
- Updated references in tests, logging labels, and module exports to reflect the new name.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/commands/app/clean.test.js | Updated require statement, describe string, and instantiation to use "Clean" |
| src/commands/app/clean.js | Renamed class, updated logging identifier, description, flags, and export to "Clean" |
pru55e11
approved these changes
May 6, 2025
dthampy
approved these changes
May 6, 2025
Contributor
dthampy
left a comment
There was a problem hiding this comment.
Looks good! Sorry that you had to the extra work
MichaelGoberling
approved these changes
May 6, 2025
purplecabbage
added a commit
that referenced
this pull request
Nov 10, 2025
* clean-build becomes just clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request renames the command from CleanBuild to Clean to simplify the terminology.
Renames the command class and references in the source and test files.
Updates descriptions and exports accordingly.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: