Skip to content

nit: added comment for clarity#864

Merged
shazron merged 3 commits intomasterfrom
nit-add-comment
Jun 16, 2025
Merged

nit: added comment for clarity#864
shazron merged 3 commits intomasterfrom
nit-add-comment

Conversation

@purplecabbage
Copy link
Copy Markdown
Member

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (215f2c0) to head (688170a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #864   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3263      3263           
  Branches       631       631           
=========================================
  Hits          3263      3263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@purplecabbage purplecabbage requested a review from Copilot May 21, 2025 20:04
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes minor updates by adding clarifying comments to reflect that the local development option (--local) is no longer applicable in the RuntimeLib API.

  • Updated comment texts in multiple locations.
  • Adjusted getActionUrls parameter values to align with the new behavior.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/lib/run-dev.js Updated inline comment and adjusted getActionUrls parameters.
src/lib/app-helper.js Added clarifying comments regarding the removal of the --local flag.
src/commands/app/build.js Added similar clarifying comments in the build command for consistency.

@shazron shazron merged commit fb1226c into master Jun 16, 2025
10 checks passed
@shazron shazron deleted the nit-add-comment branch June 16, 2025 11:17
purplecabbage added a commit that referenced this pull request Nov 10, 2025
Co-authored-by: Shazron Abdullah <36107+shazron@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants