Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #869 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 57 57
Lines 3254 3251 -3
Branches 630 630
=========================================
- Hits 3254 3251 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
moritzraho
approved these changes
May 28, 2025
dthampy
approved these changes
May 28, 2025
purplecabbage
approved these changes
May 28, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates the audit log event-post API to no longer include the projectId, workspaceId, and workspaceName fields in the event payload since these values are now obtained via the access token namespace. Key changes include:
- Removing projectId, workspaceId, and workspaceName from the audit log event object in src/lib/audit-logger.js.
- Updating tests in test/commands/lib/audit-logger.test.js to reflect the new API behavior.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/lib/audit-logger.js | Removed assignment and payload properties for project/workspace info. |
| test/commands/lib/audit-logger.test.js | Removed expectations for project/workspace fields in audit event tests. |
purplecabbage
pushed a commit
that referenced
this pull request
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Needs Deploy Service change in ACNA-3885.
Motivation and Context
event-postAPI change.How Has This Been Tested?
aio plugins link .this PR branchAIO_DEPLOY_SERVICE_URLtohttp://localhost:3000aio app deployTypes of changes
Checklist: