Partials v2 gen by arnaud-lb · Pull Request #22 · arnaud-lb/php-src

arnaud-lb · 2025-09-08T16:46:58Z

PFAs are created by generating the AST of a Closure at runtime and compiling it. The compiled op_array can be cached similarly to linked classes.

About caching

There are three levels of caching:

The global opcache (ZCG(hash))
EG(partial_function_application_cache)
The caller's run time cache

The cache key in ZCG(hash) is composed of the address of the declaring opline, the address of the function being called, and a prefix.

EG(partial_function_application_cache) is used when opcache is disabled, or when the PFA can not be cached in SHM (e.g. because the actual function itself is not cached). This is mostly useful in CLI (opcache is disabled by default) for polymorphic PFAs (inline cache less useful).

TODO

TimWolla · 2025-11-03T17:14:50Z

Can we get a test case where the function has optional arguments and an incorrect number is given (just to see the error message once).

This test shows this error message: https://github.com/arnaud-lb/php-src/blob/75dbd22353d81d34d63587f9c703523f5d10b82e/Zend/tests/partial_application/rfc_examples_003.phpt
Do you prefer a dedicated test case?

Great, I just realize that the error messages for userland and native functions are already inconsistent with each other:

https://3v4l.org/3G8EO

TimWolla · 2025-11-18T15:40:19Z

+ZEND_API bool zend_check_type_ex(
+		const zend_type *type, zval *arg, zend_class_entry *scope,
+		bool is_return_type, bool is_internal)
+{
+	return zend_check_type(type, arg, scope, is_return_type, is_internal);
+}


What's the purpose of this? Wouldn't it work to expose zend_check_type() directly?

It's not that easy, as the function is always_inline, and uses always_inline functions from this file as well. zend_check_type() is critical, I didn't want to take the risk of performance regression.

So we have the following options:

Move the function and a bunch of functions it uses to a header file (zend_check_type, zend_check_type_slow, zend_check_intersection_type_from_list, probably others), so we don't lose inline-ability

Make the function extern inline, but we don't do that (there was a thread about that in a PR).

Export a wrapper, like I did here

I will think about about the other options

* PHP-8.4: Fix phpGH-21698: memory leak in ZipArchive::addGlob on early returns.

* PHP-8.5: [skip ci] Sort paths-ignore and remove cirrus [skip ci] Tweak paths-ignore

* PHP-8.2: [skip ci] Mark curl/bug71523.phpt as online test

* PHP-8.3: [skip ci] Mark curl/bug71523.phpt as online test

* PHP-8.4: [skip ci] Mark curl/bug71523.phpt as online test

* PHP-8.5: [skip ci] Mark curl/bug71523.phpt as online test

…e` checks (php#21820) The phar_archive_data->alias field is only ever assigned a newly allocated char* or NULL, as such it can never be equal to the phar_archive_data->fname field, thus those comparisons are just confusing.

* PHP-8.4: PHP 8.4 is now for PHP 8.4.22-dev

* PHP-8.5: PHP 8.4 is now for PHP 8.4.22-dev

Clang supports __has_attribute(cold) but not __attribute__((optimize(...))). The cold and optimize branches need to be split.

…hp#10419)

…ntersection type list (php#21717) When generating a union or intersection type list with multiple class types, the variable holding each zend_string* was declared using toVarEscapedName() (backslashes replaced by underscores), but the subsequent ZEND_TYPE_INIT_CLASS() reference used toEscapedName() (backslashes escaped as \\), producing an invalid C identifier. Backported to PHP 8.5.

* PHP-8.5: gen_stub: fix invalid C variable name for namespaced types in union/intersection type list (php#21717)

* PHP-8.5: PHP-8.5 is now for PHP 8.5.7-dev

To increase legibility

This char* is derived from the fname char* field.

As this is derived from a live char* pointer where we don't have the ownership.

… on DOM-built documents. For programmatically built documents (e.g. createElementNS), namespaces live on node->ns without corresponding xmlns attributes. Create temporary synthetic nsDef entries so C14N can find them, complementing the existing xmlns attribute to nsDef conversion. close phpGH-21561

* PHP-8.4: Fix phpGH-21544: Dom\XMLDocument::C14N() drops namespace declarations on DOM-built documents.

* PHP-8.5: Fix phpGH-21544: Dom\XMLDocument::C14N() drops namespace declarations on DOM-built documents.

Change zend_function_entry.flags to a uint64_t to that both ZEND_ACC_ and ZEND_ACC2_ flags can be represented. Introduce ZEND_FENTRY_FLAGS(flags, flags2) to pass ZEND_ACC2_ flags to ZEND_RAW_FENTRY(), ZEND_FENTRY(). Source-level backwards compatibility is maintained, as passing raw ZEND_ACC_ flags to ZEND_RAW_FENTRY(), ZEND_FENTRY() still works.

Functions that use zend_forbid_dynamic_call() must be flagged with ZEND_ACC2_FORBID_DYN_CALLS. In stubs, this is done by using @forbid-dynamic-calls. To ensure consistency, we assert that the flag exists in zend_forbid_dynamic_call(), and we assert that flagged functions thrown after a dynamic call. Closes phpGH-21818

RFC: https://wiki.php.net/rfc/partial_function_application_v2 Co-authored-by: Joe Watkins <krakjoe@php.net>

arnaud-lb force-pushed the partials-v2-gen branch 3 times, most recently from 7062e66 to f65bf45 Compare September 13, 2025 10:37

TimWolla reviewed Oct 3, 2025

View reviewed changes

Comment thread Zend/tests/partial_application/errors_001.phpt

Comment thread Zend/tests/partial_application/clone.phpt Outdated

Comment thread Zend/tests/partial_application/compile_errors_001.phpt Outdated

arnaud-lb force-pushed the partials-v2-gen branch 2 times, most recently from d820a4f to 75dbd22 Compare November 3, 2025 17:04

TimWolla reviewed Nov 3, 2025

View reviewed changes

Comment thread Zend/zend_ast.c Outdated

Comment thread Zend/zend_ast.c Outdated

Comment thread Zend/zend_ast.c Outdated

arnaud-lb force-pushed the partials-v2-gen branch 2 times, most recently from bf4b4f6 to b753b0c Compare November 3, 2025 18:55

TimWolla reviewed Nov 3, 2025

View reviewed changes

TimWolla reviewed Nov 18, 2025

View reviewed changes

Comment thread ext/opcache/ZendAccelerator.c Outdated

arnaud-lb force-pushed the partials-v2-gen branch from 5b8cfc2 to 65a21f2 Compare December 10, 2025 17:20

arnaud-lb changed the base branch from master to tmp-master December 10, 2025 17:35

arnaud-lb changed the base branch from tmp-master to master December 10, 2025 17:35

TimWolla reviewed Dec 15, 2025

View reviewed changes

Comment thread Zend/tests/partial_application/fuzz_003.phpt Outdated

Comment thread Zend/tests/partial_application/fuzz_004.phpt Outdated

Comment thread Zend/tests/partial_application/reflection_004.phpt Outdated

Comment thread Zend/tests/partial_application/rfc_examples_010.phpt Outdated

arnaud-lb force-pushed the partials-v2-gen branch from e1a4016 to 1616f33 Compare December 16, 2025 11:58

arnaud-lb changed the base branch from master to tmp-master December 16, 2025 12:00

arnaud-lb changed the base branch from tmp-master to master December 16, 2025 12:00

arnaud-lb mentioned this pull request Dec 16, 2025

[PFA 1/n] Support PFA syntax php/php-src#20717

Closed

arnaud-lb force-pushed the partials-v2-gen branch 2 times, most recently from 0b7a4a5 to 2cf2ae1 Compare January 8, 2026 11:32

arnaud-lb force-pushed the partials-v2-gen branch 4 times, most recently from a3a4549 to 8514af4 Compare January 19, 2026 12:18

arnaud-lb force-pushed the partials-v2-gen branch from 88ff9da to 5b844c6 Compare February 14, 2026 12:19

arnaud-lb force-pushed the partials-v2-gen branch from 3fe1b9f to 5a3de00 Compare March 12, 2026 17:26

Merge branch 'PHP-8.4' into PHP-8.5

493b59a

* PHP-8.4: Fix phpGH-21698: memory leak in ZipArchive::addGlob on early returns.

iluuu1994 and others added 29 commits April 21, 2026 14:47

Merge branch 'PHP-8.5'

fc8f56c

* PHP-8.5: [skip ci] Sort paths-ignore and remove cirrus [skip ci] Tweak paths-ignore

[skip ci] Mark curl/bug71523.phpt as online test

d60e7a1

Merge branch 'PHP-8.2' into PHP-8.3

505e9fe

* PHP-8.2: [skip ci] Mark curl/bug71523.phpt as online test

Merge branch 'PHP-8.3' into PHP-8.4

ed1b00c

* PHP-8.3: [skip ci] Mark curl/bug71523.phpt as online test

Merge branch 'PHP-8.4' into PHP-8.5

f8b1f08

* PHP-8.4: [skip ci] Mark curl/bug71523.phpt as online test

Merge branch 'PHP-8.5'

f63be32

* PHP-8.5: [skip ci] Mark curl/bug71523.phpt as online test

PHP 8.4 is now for PHP 8.4.22-dev

aeb5671

Merge branch 'PHP-8.4' into PHP-8.5

cb363ec

* PHP-8.4: PHP 8.4 is now for PHP 8.4.22-dev

Merge branch 'PHP-8.5'

61eb31a

* PHP-8.5: PHP 8.4 is now for PHP 8.4.22-dev

Fix usage of optimize attribute on unsupported compilers (phpGH-21819)

355571c

Clang supports __has_attribute(cold) but not __attribute__((optimize(...))). The cold and optimize branches need to be split.

ext/mysqli: Throw error when mysql_stmt_data_seek cannot be executed (p…

637c116

…hp#10419)

Merge branch 'PHP-8.5'

e88a9d1

* PHP-8.5: gen_stub: fix invalid C variable name for namespaced types in union/intersection type list (php#21717)

PHP-8.5 is now for PHP 8.5.7-dev

c6ef114

Merge branch 'PHP-8.5'

239a8be

* PHP-8.5: PHP-8.5 is now for PHP 8.5.7-dev

ext/phar: reduce scope of variables and clean up CS

9d53371

ext/phar: no longer assign to variables in if conditions

4195fc4

To increase legibility

ext/phar: mark _phar_archive_data.ext field as const

c5a3f46

This char* is derived from the fname char* field.

ext/phar: mark last_phar_name global cache field as const

60b2d0d

As this is derived from a live char* pointer where we don't have the ownership.

Merge branch 'PHP-8.4' into PHP-8.5

86a1b36

* PHP-8.4: Fix phpGH-21544: Dom\XMLDocument::C14N() drops namespace declarations on DOM-built documents.

Merge branch 'PHP-8.5'

ee3addf

* PHP-8.5: Fix phpGH-21544: Dom\XMLDocument::C14N() drops namespace declarations on DOM-built documents.

Partial application

0bbb3ce

RFC: https://wiki.php.net/rfc/partial_function_application_v2 Co-authored-by: Joe Watkins <krakjoe@php.net>

Squashed changes

94a88c6

Use ZEND_ACC2_FORBID_DYN_CALLS

e775c27

Comment

a7331b1

arnaud-lb force-pushed the partials-v2-gen branch from bbd5068 to a7331b1 Compare April 22, 2026 08:53

Conversation

arnaud-lb commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

About caching

TODO

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TimWolla Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

arnaud-lb Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

TimWolla Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TimWolla Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

arnaud-lb Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

arnaud-lb commented Sep 8, 2025 •

edited

Loading