fix(cloudfront): replace random.randint with uuid4 for CallerReference generation#10282
Open
tomohiro86 wants to merge 1 commit intoaws:developfrom
Open
fix(cloudfront): replace random.randint with uuid4 for CallerReference generation#10282tomohiro86 wants to merge 1 commit intoaws:developfrom
tomohiro86 wants to merge 1 commit intoaws:developfrom
Conversation
…e generation unique_string() was using random.randint(1, 1000000) combined with a Unix timestamp to generate CallerReference values for create-invalidation and create-distribution. Because the timestamp has 1-second granularity, concurrent invocations within the same second had a 1-in-1,000,000 chance of producing identical values, causing CloudFront to silently treat the second request as a duplicate. Replace with uuid.uuid4() which provides 122 bits of cryptographic randomness, eliminating both the timestamp dependency and collision risk. Fixes aws#10281
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unique_string()inawscli/customizations/cloudfront.pywas generatingCallerReferencevalues usingrandom.randint(1, 1000000)combined with a Unix timestamp (1-second granularity)CallerReference, causing CloudFront to silently treat the second request as a duplicateuuid.uuid4()which provides 122 bits of cryptographic randomness, eliminating both the collision risk and the unnecessary timestamp dependencyFixes #10281
Test plan
create-invalidation --pathsgenerates a uniqueCallerReferenceon each invocationcreate-distributiongenerates a uniqueCallerReferenceon each invocationpytest tests/unit/customizations/test_cloudfront.py