Skip to content

chore(deps-dev): bump types-colorama from 0.4.15.20250801 to 0.4.15.20260408 #8902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 4 commits into
base: develop
Choose a base branch
from
+2 −2
Open

chore(deps-dev): bump types-colorama from 0.4.15.20250801 to 0.4.15.20260408 #8902

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe0eb14
chore(deps-dev): bump types-colorama
dependabot[bot] Apr 8, 2026
3de804c
Merge branch 'develop' into dependabot/pip/develop/types-colorama-0.4…
Vandita2020 May 5, 2026
2b6b70b
Merge branch 'develop' into dependabot/pip/develop/types-colorama-0.4…
Vandita2020 May 6, 2026
fde2d9d
Merge branch 'develop' into dependabot/pip/develop/types-colorama-0.4…
roger-zhangg May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ dev = [
"types-psutil==7.2.2.20260130",
"types-setuptools==82.0.0.20260408",
"types-Pygments==2.19.0.20251121",
"types-colorama==0.4.15.20250801",
"types-dateparser==1.4.0.20260408",
"types-colorama==0.4.15.20260408",
"types-dateparser==1.4.0.20260328",
Copy link
Copy Markdown
Collaborator

@aws-sam-cli-bot aws-sam-cli-bot May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[GENERAL] This PR is titled as a bump of types-colorama only, but it also modifies an unrelated dependency: types-dateparser is being changed from 1.4.0.20260408 to 1.4.0.20260328, which is a downgrade (March 28, 2026 is earlier than April 8, 2026 in the typeshed YYYYMMDD stub suffix scheme).

Scope-wise, a Dependabot PR whose description mentions only types-colorama should not touch other dependency lines. Two concerns:

  1. The change is out of scope for the stated PR and is not documented in the description, making it easy to merge without review.
  2. It silently rolls back types-dateparser stubs by ~11 days, which may re-introduce stub bugs or type errors that were fixed in the newer release.

Before merging, please either:

  • Revert the types-dateparser line back to 1.4.0.20260408 so this PR only bumps types-colorama as advertised, or
  • Update the PR title/description to reflect that types-dateparser is intentionally being pinned to 1.4.0.20260328 and explain why the downgrade is needed.
- "types-colorama==0.4.15.20250801",
- "types-dateparser==1.4.0.20260408",
+    "types-colorama==0.4.15.20260408",
+    "types-dateparser==1.4.0.20260328",

Copy link
Copy Markdown
Collaborator

@aws-sam-cli-bot aws-sam-cli-bot May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[GENERAL] This PR is titled as a bump of types-colorama only, but it also modifies an unrelated dependency on the same hunk: types-dateparser is changed from 1.4.0.20260408 to 1.4.0.20260328.

Two problems with this change:

  1. Out of scope. Dependabot PRs are scoped to a single dependency, and the PR title/description only mention types-colorama. Modifying types-dateparser here is unexpected and makes the change harder to audit and revert independently.
  2. It is a downgrade. In the typeshed stub versioning scheme, the trailing YYYYMMDD suffix is the stub release date. 20260328 (March 28, 2026) is earlier than 20260408 (April 8, 2026), so this moves types-dateparser backwards to an older stub release, which can reintroduce type-stub bugs or drop typing fixes that the newer stubs contained.

Please revert the types-dateparser line back to 1.4.0.20260408 in this PR and, if a real downgrade of types-dateparser is intended, handle it in a separate, explicitly-scoped PR that justifies the regression.

"types-colorama==0.4.15.20260408",
   "types-dateparser==1.4.0.20260408",

This was flagged in the previous review and has not been addressed or explicitly dismissed by the author, so re-raising.

"types-docutils==0.22.3.20260322",
"types-jsonschema==4.26.0.20260202",
"types-pyOpenSSL==24.1.0.20240722",
Expand Down
Loading