correcting runtime versions in integ test#8947
correcting runtime versions in integ test#8947Vandita2020 wants to merge 1 commit intoaws:developfrom
Conversation
|
Is there an integration test running for these updated cases? |
aws-sam-cli-bot
left a comment
There was a problem hiding this comment.
Code Review Results
Reviewed: a40fb27..427bec6
Files: 14
Comments: 1
Comments on lines outside the diff:
[tests/integration/validate/test_validate_command.py:214] [GENERAL] nodejs20.x was removed from supported_runtimes, but it was not added to the test_lint_deprecated_runtimes parametrize list (currently: nodejs, python3.9, nodejs18.x, ruby3.2, dotnet6). If the reason for the removal is that cfn-lint now reports nodejs20.x as deprecated (the most likely cause of the test_lint_supported_runtimes failure this PR is fixing), then dropping it from the supported list without adding it to the deprecated list means the project loses all linter coverage for that runtime. Consider adding it to the deprecated cases so the deprecation path is actually exercised:
@parameterized.expand(
[
("nodejs",),
("python3.9",),
("nodejs18.x",),
("nodejs20.x",),
("ruby3.2",),
("dotnet6",),
]
)
def test_lint_deprecated_runtimes(self, runtime):This also addresses the unresolved question from the previous review about integration-test coverage for the updated runtime cases. If nodejs20.x is not yet fully deprecated by cfn-lint (only warning, etc.), please note the intent in the PR so the gap is explicit.
|
Integration tests: https://github.com/aws/aws-sam-cli/actions/runs/25461443031 |
Which issue(s) does this change fix?
NA
Why is this change necessary?
Fixes the integration test failure:
terraform-build
other-and-e2e
tier1-windows-build-2
How does it address the issue?
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.