Skip to content

fix: handle empty URL parts in edit_uri to prevent TypeError #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suraj-aleph wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −2
Open

fix: handle empty URL parts in edit_uri to prevent TypeError #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions mkdocs_monorepo_plugin/edit_uri.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,12 @@ def __get_root_docs_dir(self):

def __get_page_dir_alias(self):
parts = self.page.url.split("/")
while True:
while parts:
parts.pop()
alias = path.join(*parts)
alias = path.join(*parts) if parts else ""
if alias in self.plugin.aliases:
return alias
return None

def __get_page_docs_dir(self):
alias = self.__get_page_dir_alias()
Expand Down Expand Up @@ -102,6 +103,8 @@ def __is_root(self):
def build(self):
if self.__is_root():
return self.page.edit_url
if self.__get_page_dir_alias() is None:
return self.page.edit_url
if self.__has_repo():
config = self.__get_page_config_file_yaml()
return config["repo_url"] + config["edit_uri"] + self.__get_page_src_path()
Expand Down