Distinct guards for exported and non exported prototypes.#2
Open
Kerilk wants to merge 37 commits into
Open
Conversation
passing header tests with generated headers improve generation for extensions that share type names remove incorrectly added file update to latest generated files
The function pointers in cl_layer.h currently use a different convention in the ICD loader. Alternatives are to align to the cl_layer.h convention, to not generate this header, or to figure out how to selectively generate a different convention in some cases.
handle functions with no arguments
appended EXTENSION_NAME to extension name define
cl_khr_semaphore cl_khr_external_semaphore (and related extensions) cl_khr_external_memory (and related extensions) cl_intel_device_attribute_query
Done by shifting the unsigned long long literal 1ULL. This is done conditionally for now, only when the shift amount is greater than 31, because shifting by 31 or less is defined.
cl_intel_program_scope_host_pipe
This is needed for cl_ext_image_requirements_info where the entire extension is guarded by an ifdef vs. particular blocks of the extension.
cl_khr_command_buffer_mutable_dispatch cl_ext_image_requirements_info cl_intel_queue_no_sync_operations
For easier initial review, generate extensions in the same order as the existing files. This can be switched to a more regular order later.
12 tasks
Author
|
MacOS test has been flaky the last few days but passed here: https://github.com/Kerilk/OpenCL-Headers/actions/runs/4492498287 |
…queueWriteHostPipeINTEL
Kerilk
force-pushed
the
generate-extension-headers-guards
branch
from
9ec6ead to
a180d6e
Compare
Author
|
fix for CI is here https://github.com/KhronosGroup/OpenCL-Headers/pull/225/files |
bashbaug
force-pushed
the
generate-extension-headers
branch
from
6c196d2 to
16ace9e
Compare
bashbaug
force-pushed
the
generate-extension-headers
branch
from
16ace9e to
95e6f78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the suggestion I made here:
KhronosGroup#161 (comment)
This should allow building the loader by defining
CL_NO_EXTENSION_PROTOTYPESrather thanCL_NO_PROTOTYPES