feat: add theme.state opacity tokens and split theme types#4917
Open
adrcotfas wants to merge 2 commits into@adrcotfas/refactor/tokens_colorsfrom
Open
feat: add theme.state opacity tokens and split theme types#4917adrcotfas wants to merge 2 commits into@adrcotfas/refactor/tokens_colorsfrom
adrcotfas wants to merge 2 commits into@adrcotfas/refactor/tokens_colorsfrom
Conversation
|
The mobile version of example app from this branch is ready! You can see it here. |
|
Hey @adrcotfas, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
This was referenced May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
1.
theme.statewas missing.Interaction-state opacities (hover, focus, press, drag) lived in the raw token layer but were never on the theme object. Components had to reach into the token layer directly, bypassing theme
overrides.
theme.state.opacityfixes that.2.
src/theme/types.tswas getting too big.All theme types lived in one 179-line file. Split into
src/theme/types/one file per concern so new types (likeThemeState) have a clear place to go.No behavior changes for existing consumers:
Themegains one new required field (state), all built-in schemes populate it, and the barrel re-exports everything from the same path.Related issue
See https://www.notion.so/callstack/React-Native-Paper-Foundation-for-MD3-Expressive-34c5d027c0f880edba3df107cd35946f?source=copy_link
refactor: remove MD3 prefix and use deprecated aliases #4910
refactor: move styles/ into src/theme/ tree #4915
refactor: add color role table and buildScheme #4916
feat: add theme.state opacity tokens and split theme types #4917
feat: add theme.shapes and cornersToStyle #4919
feat: add emphasized typescale and fix letter-spacing spec bugs #4920
feat: add motion tokens (spring, easing, duration) #4922
feat: add elevation tokens and fix Android dp spec bug #4923
Test plan
yarn typescript-- no new type errorsyarn test-- all tests pass; updatedListSectionsnapshot reflects the newstatefield