Bumped to SpringBoot4, SpringFramework7 and JDK17 - same as #705, but with signed-ff commits#729
Bumped to SpringBoot4, SpringFramework7 and JDK17 - same as #705, but with signed-ff commits#729jacekbilski wants to merge 21 commits intocloudevents:mainfrom
Conversation
Signed-off-by: David Strömner <david.stromner@stralfors.se>
Signed-off-by: David Strömner <david.stromner@stralfors.se>
Signed-off-by: David Strömner <david.stromner@stralfors.se>
Signed-off-by: David Strömner <david.stromner@stralfors.se>
Signed-off-by: David Strömner <david.stromner@stralfors.se>
Signed-off-by: David Strömner <david.stromner@stralfors.se>
Signed-off-by: David Strömner <david.stromner@stralfors.se>
Signed-off-by: David Strömner <david.stromner@stralfors.se>
Signed-off-by: Jacek Bilski <jacek@bilski.tech>
Signed-off-by: Jacek Bilski <jacek@bilski.tech>
Signed-off-by: Jacek Bilski <jacek@bilski.tech>
Signed-off-by: Jacek Bilski <jacek@bilski.tech>
Signed-off-by: Jacek Bilski <jacek@bilski.tech>
Signed-off-by: Jacek Bilski <jacek@bilski.tech>
Signed-off-by: Jacek Bilski <jacek@bilski.tech>
…on)" OpenRewrite recipe. Signed-off-by: Jacek Bilski <jacek@bilski.tech>
Signed-off-by: Jacek Bilski <jacek@bilski.tech>
…ttps://github.com/spring-cloud/spring-cloud-function/tree/main/spring-cloud-function-samples/function-sample-cloudevent. Signed-off-by: Jacek Bilski <jacek@bilski.tech>
Signed-off-by: Jacek Bilski <jacek@bilski.tech>
|
Hey guys, are you planning to merge this soon? It's blocking Spring Boot upgrades because of Jackson 3 breaking changes. |
|
I wish I could say more. I believe that @stromner-stralfors and I have made all the necessary changes, the code works for me™. Anything beyond that is in the hands of the maintainers. |
|
@duglin Can you answer if this is something you (the maintainers, not specifically you) will be working on? |
|
@lbenedetto let me poke some folks |
|
Seems reasonable to me, however, with such a large number of files changed (and some being more than just a version number change), let's wait for @Cali0707 to verify that nothing seems off. |
|
yes currently taking a look here (started yesterday, but lots of changes...) |
There was a problem hiding this comment.
Hey @jacekbilski thanks for all the much needed hard work to modernize this SDK!
I think to make these changes more releasable we need to split this up into a couple more incremental PRs/releases:
- Let's mark
http/restful-ws's public classes as@Deprecated(forRemoval = true). As part of this, we should copy the code intohttp/restful-ws-jakartaand permanently switch thejavaxtojakartanamespacing. We do not want to remove therestful-ws-jakartasupport in 5.0 (and can't remove either currently as neither module is actually marked as deprecated, despite the commit comment saying they are). - Make a 4.1.0 release after step 1 is merged
- Bump to Java 17 baseline and apply the language modernization changes (version bump to 5.0.0-SNAPSHOT)
- Drop the
restful-wsmodule and updaterestful-ws-jakartato Jakarta REST 4.0 - Apply the
HttpHeadersdefensive copy fix and the@Nullableannotation switch (these are both needed for Spring Boot 4 forward compatibility), but keep compiling and testing against Spring Boot 3.x. This way users on both 3.x and 4.x can use the module. I thinking moving from the current 2.x all the way to 4.x in one go is too aggressive and will make it so some users can not use this.
I don't think we need to bump to Jackson 3 currently, as there is still a large portion of projects on Jackson 2. Additionally, let's stick with JUnit 5 for now to help keep the scope of changes smaller.
If you are able to start working on pieces of this in separate PRs, ping me and I'm happy to try to quickly merge them and move this process along!
The content is the same as in #705, see the discussion there. The only two changes are: the commits are now properly signed-off and I've rebased it onto main.