feat: add access context types#6735
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6735 +/- ##
==========================================
- Coverage 66.62% 66.61% -0.01%
==========================================
Files 402 402
Lines 115914 115937 +23
Branches 19425 19428 +3
==========================================
+ Hits 77226 77230 +4
- Misses 27095 27111 +16
- Partials 11593 11596 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
petebacondarwin
left a comment
petebacondarwin
left a comment
There was a problem hiding this comment.
Feels like we need to run the snapshots against clean main to remove the extra unexpected types?
| }; | ||
| export { _EmailMessage as EmailMessage }; | ||
| } | ||
| /** |
There was a problem hiding this comment.
Why are these types here? It looks like the snapshot generation has pulled in "Flag" stuff too?
There was a problem hiding this comment.
I just tried pulling main with no local changes and ran just generate-types and get these changes as well. It seems the original PR that added these types did not run this command?
There was a problem hiding this comment.
flags shouldn't be here, this seems wrong
Signed-off-by: Matt Provost <mprovost@cloudflare.com>
Signed-off-by: Matt Provost <mprovost@cloudflare.com>
Signed-off-by: Matt Provost <mprovost@cloudflare.com>
Signed-off-by: Matt Provost <mprovost@cloudflare.com>
this should be more in line with workerd architecture. we separate the polymorphism to something that AccessContext wraps around rather than having AccessContext itself be polymorphic. Signed-off-by: Matt Provost <mprovost@cloudflare.com>
Merging this PR will improve performance by 13.76%
Performance Changes
Comparing 
Footnotes
|
5 participants
Replaces #6413 and #6549.
Adds types for Cloudflare Access integration into Workers