Skip to content

Cleaner binary check#717

Merged
chombium merged 1 commit intocloudfoundry:mainfrom
jorbaum:minor-test-script-improvements
May 4, 2026
Merged

Cleaner binary check#717
chombium merged 1 commit intocloudfoundry:mainfrom
jorbaum:minor-test-script-improvements

Conversation

@jorbaum
Copy link
Copy Markdown
Contributor

@jorbaum jorbaum commented Feb 23, 2026

Description

While working on cloudfoundry/go-loggregator#79 I found two things that I found worth adding to the test scripts:

  • reuse ginkgo instead of recompiling every time, same as we are already doing with golangci-lint
  • cleaner check for binary removing three lines of code ;)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

@jorbaum jorbaum force-pushed the minor-test-script-improvements branch from 8f021ec to 5ed3da6 Compare April 23, 2026 13:39
Comment thread scripts/subtests/unit-test Outdated
@jorbaum jorbaum force-pushed the minor-test-script-improvements branch from 5ed3da6 to dafa1e9 Compare April 28, 2026 15:05
@jorbaum jorbaum changed the title Reuse installed ginkgo and use cleaner binary check Cleaner binary check Apr 28, 2026
@jorbaum jorbaum requested a review from ZPascal April 29, 2026 07:23
Copy link
Copy Markdown

@ZPascal ZPascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Application Runtime Platform Working Group May 4, 2026
@chombium chombium merged commit 1bfac28 into cloudfoundry:main May 4, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Application Runtime Platform Working Group May 4, 2026
@jorbaum jorbaum deleted the minor-test-script-improvements branch May 4, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants