chore: redact _artifacts tokens, fix e2e run & clean-up container images#16
Merged
chore: redact _artifacts tokens, fix e2e run & clean-up container images#16
Conversation
mweibel
force-pushed
the
redact-artifacts
branch
from
46dcf42 to
13d1c1d
Compare
e2e tests don't work in v1.12.x because of transitive dependency to k8s 0.34.x and we do have 0.35.x dependency. Downgrading to 0.34.x is not possible because we have a too new controller-runtime. Due to the fact that CAPI 1.13 will be released probably soon, it should be fine to depend on 1.13.
quay.io would need an oauth application otherwise, which would have access to the whole organization. This defeats the point of blast radius reduction.
mweibel
force-pushed
the
redact-artifacts
branch
from
79d5bc5 to
5288d13
Compare
mweibel
changed the title
mweibel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes three things tied to releasing & e2e testing:
Redact tokens:
Redact known tokens in _artifacts which are uploaded to GitHub artifacts after every test run to make it debuggable. The redact step ensures the uploaded files don't contain the API token. Old artifacts haven been cleaned up.
upgrade to CAPI v1.13.0-beta.0
e2e tests don't work in v1.12.x because of transitive dependency to
k8s 0.34.x and we do have 0.35.x dependency. Downgrading to 0.34.x is
not possible because we have a too new controller-runtime.
Due to the fact that CAPI 1.13 will be released probably soon, it should
be fine to depend on 1.13.
This was initially in the e2e-tests branch as-is, but then in the public-releases branch got reverted again but never tested unfortunately.
use regctl to delete container tags
quay.io would need an oauth application if we use the regular REST API, which would have access to the whole organization. This defeats the point of blast radius reduction. Use regctl instead to delete old tags.