Skip to content

fix: handle date format for e2e cleanup#25

Merged
mweibel merged 1 commit intomainfrom
cleanup-fix
Apr 22, 2026
Merged

fix: handle date format for e2e cleanup#25
mweibel merged 1 commit intomainfrom
cleanup-fix

Conversation

@mweibel
Copy link
Copy Markdown
Collaborator

@mweibel mweibel commented Apr 22, 2026

fixes issue with cleanup reported here: https://github.com/cloudscale-ch/cluster-api-provider-cloudscale/actions/runs/24622224615/job/71994951165

and fixes a shellcheck issue:

In hack/clean-e2e-images.sh line 24:
cutoff=$(date -u -v-${MAX_AGE_DAYS}d +%s 2>/dev/null || date -u -d "${MAX_AGE_DAYS} days ago" +%s)
                    ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
cutoff=$(date -u -v-"${MAX_AGE_DAYS}"d +%s 2>/dev/null || date -u -d "${MAX_AGE_DAYS} days ago" +%s)

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ..

@mweibel mweibel merged commit 816178f into main Apr 22, 2026
6 checks passed
@mweibel mweibel deleted the cleanup-fix branch April 22, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant