Conversation
mweibel
reviewed
Apr 27, 2026
mweibel
left a comment
mweibel
left a comment
There was a problem hiding this comment.
Looks good overall - I have a few questions.
The tests didn't go through but judging by the tests these were because of unrelated issues. I think you addressed those in a separate PR, right?
Contributor
Author
Yes. |
mweibel
reviewed
May 4, 2026
mweibel
left a comment
mweibel
left a comment
There was a problem hiding this comment.
Generally looks good to me, just two small things to comment, and a note to not forget updating the dependency again.
The cloudscale API only accepts name, volume_snapshot_uuid, and tags when creating a volume from a snapshot. To let users specify size_gb and server_uuids alongside a snapshot, the provider now creates the volume first, then resizes and/or attaches via Update calls. Use resourceName variable consistently in volume tests.
All resources that wait for a status during create (server, load balancer, volume snapshot) made two API calls per poll: one via the generic Read helper to populate schema.ResourceData, then a second direct Get to obtain the object. Replace both with a single Get and look up the attribute via the existing gather*ResourceData function.
alakae
force-pushed
the
alain/snaps
branch
2 times, most recently
from
a6c6f19 to
92c9c90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In scope:
Out of scope:
Closes #92