Fix adoption link not prioritized in Mastodon#99
Open
patrickZWY wants to merge 12 commits into
Open
Conversation
patrickZWY
commented
May 11, 2026
| packaging==26.2 | ||
| pluggy==1.6.0 | ||
| Pygments==2.20.0 | ||
| pytest==9.0.3 |
Collaborator
Author
There was a problem hiding this comment.
pytest was not needed in requirements before i think
| from abstractions import AdoptablePet | ||
| from social_posters.mastodon import PosterMastodon | ||
|
|
||
| def postExceed500CharsLimitWithAdoptionLink(): |
Collaborator
There was a problem hiding this comment.
python function should follow snake_case fyi as a convention
| from abstractions import AdoptablePet | ||
| from social_posters.mastodon import PosterMastodon | ||
|
|
||
| def postExceed500CharsLimitWithAdoptionLink(): |
Collaborator
There was a problem hiding this comment.
Suggested change
| def postExceed500CharsLimitWithAdoptionLink(): | |
| def post_exceed_500_chars_limit_with_adoption_link(): |
Collaborator
Author
|
gonna wait until my test account is recovered and i want to see how it looks in test account for my newly implemented comment section splitting thingy |
…Boston into mastodon-fix-link merge
Collaborator
Author
testing account recovery rejected. I will open a new account for testing purpose and this time significantly reduce manual testing and clean up after testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mastodon and the domain we use for Mastodon posting has a strict 500 word limit. Since Mastodon implementation uses default caption formatting in abstractions, it also puts the link below the body of the caption. When text goes near or over 500 word limit, then link gets buried. Prioritize the link by overriding the default function and rearranging it at the top.
Now also putting content exceeding 500 chars limit to comment section, max replies is 5, extra text beyond 5 replies will be truncated.
Also modify the manual testing for Mastodon and adding a preview test to reflect this.
Remove most unnecessary dependencies in requirements.txt