Skip to content

⬆️ Bump flatted from 3.3.3 to 3.4.2#107

Open
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/npm_and_yarn/flatted-3.4.2
Open

⬆️ Bump flatted from 3.3.3 to 3.4.2#107
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/npm_and_yarn/flatted-3.4.2

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Mar 21, 2026

Bumps flatted from 3.3.3 to 3.4.2.

Commits
  • 3bf0909 3.4.2
  • 885ddcc fix CWE-1321
  • 0bdba70 added flatted-view to the benchmark
  • 2a02dce 3.4.1
  • fba4e8f Merge pull request #89 from WebReflection/python-fix
  • 5fe8648 added "when in Rome" also a test for PHP
  • 53517ad some minor improvement
  • b3e2a0c Fixing recursion issue in Python too
  • c4b46db Add SECURITY.md for security policy and reporting
  • f86d071 Create dependabot.yml for version updates
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [flatted](https://github.com/WebReflection/flatted) from 3.3.3 to 3.4.2.
- [Commits](WebReflection/flatted@v3.3.3...v3.4.2)

---
updated-dependencies:
- dependency-name: flatted
  dependency-version: 3.4.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Mar 21, 2026
Copy link
Copy Markdown

@averyjennings averyjennings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: request-changes

The PR title and description claim to bump flatted from 3.3.3 to 3.4.2 to fix CWE-1321 (prototype pollution), but the actual lockfile diff contains no changes to flatted at all.

What actually changed: get-tsconfig 4.13.0 → 4.13.6 (a transitive dep of the optional tsx package, which is itself pulled in by vitest).

Why this matters:

  • If the intent is to apply the CWE-1321 security fix in flatted, it hasn't landed. The lockfile shows no flatted version bump.
  • Merging this as-is creates a misleading record that the prototype pollution vulnerability was addressed when it wasn't.

Suggested next steps:

  1. Run grep flatted pnpm-lock.yaml — if flatted doesn't appear, it's no longer in the dependency graph and this advisory may be irrelevant.
  2. If the update is genuinely needed, run @dependabot recreate or manually pin flatted in the appropriate dependency.

The get-tsconfig side-effect bump is safe and benign on its own, but it shouldn't be merged under a misleading security framing.

@NatoBoram NatoBoram added this pull request to the merge queue May 4, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch May 4, 2026
@NatoBoram
Copy link
Copy Markdown
Collaborator

@dependabot recreate

@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot Bot commented on behalf of github May 4, 2026

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot recreate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants