Skip to content

feat: reset password pages#13

Open
ruilopesm wants to merge 8 commits intomainfrom
rl/reset-password
Open

feat: reset password pages#13
ruilopesm wants to merge 8 commits intomainfrom
rl/reset-password

Conversation

@ruilopesm
Copy link
Copy Markdown
Member

Closes #1.

@ruilopesm ruilopesm self-assigned this Aug 14, 2025
Copy link
Copy Markdown
Collaborator

@GuilhermePSF GuilhermePSF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ForgotPasswordForm uses pushEvent, ResetPasswordForm uses useLiveForm. Is there a reason?

Comment thread assets/vue/components/forgot-password/ForgotPasswordForm.vue
Comment thread assets/vue/pages/forgot-password/UserForgotPassword.vue Outdated
@ruilopesm ruilopesm requested a review from GuilhermePSF August 16, 2025 17:13
@ruilopesm ruilopesm removed the request for review from hgp22 September 3, 2025 11:28
@ruilopesm
Copy link
Copy Markdown
Member Author

Depends on a fix in live_vue, but it's good to get a code review.

Comment thread assets/vue/pages/reset-password/UserResetPassword.vue Outdated
Comment thread lib/katana/accounts/user.ex
@ruilopesm
Copy link
Copy Markdown
Member Author

Depends on a new fix from live_vue.

@pedrofp4444
Copy link
Copy Markdown
Member

pedrofp4444 commented Oct 6, 2025

I know we're still waiting from a fix from live_vue, in the meantime we can take the opportunity to translate the user feedback messages that are still in English.

image image image

Also, the email we sent is not in portuguese and does not have the final format. 🙏

image

@ruilopesm
Copy link
Copy Markdown
Member Author

@pedrofp4444 please check #47 which needs to be merged first :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reset password pages

3 participants