fix: Relax validation of names, to allow special characters, apostrophes and hyphens#876
Conversation
curlyfriesplease
changed the title
|
Tested and accented characters save correctly to the Contact Store's parquet 
|
AndyEPhipps
left a comment
AndyEPhipps
left a comment
There was a problem hiding this comment.
I guess it's not much 'wasted effort' here ahead of the centralised validation rules we discussed last week, given that'll take a wee bit time to formalise; nice one
|
Not sure if you wanted to keep tests for this purely within CRcom or not; I'm happy to do that given it's currently the only context we use this in. |
| const formMethods = useForm({ | ||
| mode: "onBlur", | ||
| resolver: yupResolver(validationSchema), | ||
| resolver: yupResolver(buildEsuValidationSchema()), |
There was a problem hiding this comment.
This wouldn't have been doing anything before - validationSchema is not exported from that file, so it would have been doing yupResolver(undefined) i.e. no validation rules
|
Added a simple schema validation test for it. |
|
🎉 This PR is included in version 8.71.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 participants
PR description
What is it doing?
José
André
Müller
François
All people who cannot currently put their proper names into ESU.
This change will relax the name regex to look for 'Letters' as defined by Unicode, rather than strictly A-Z only, which will allow characters with diacritics like those above. Also, it will allow names with apostrophes and hyphens, like J-Train and D'Snazzle.
Why is this required?
We have been adopting a similar approach elsewhere, like with FSU, so this brings some consistency.
link to Jira ticket:
ENG-5017
Quick Checklist:
My PR title follows the Conventional Commit spec.
I have filled out the PR description as per the template above.
I have added tests to cover new or changed behaviour.
I have updated any relevant documentation.
Important! - lastly, make sure to squash merge...