fix: ENG-3901 Adds additional postcode validation#437
Merged
curlyfriesplease merged 9 commits intomasterfrom Apr 14, 2026
Merged
fix: ENG-3901 Adds additional postcode validation#437curlyfriesplease merged 9 commits intomasterfrom
curlyfriesplease merged 9 commits intomasterfrom
Conversation
curlyfriesplease
changed the title
AndyEPhipps
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENG-3901
On both RND 2025 and 2026 we found there's an inconsistency between the regex used by our storybook's PostcodeLookup component, and the backend of serverless-giftaid.
We found that the backend was stricter than storybook in its validation of the outcode (the first half of a postcode) - the postcode
cro 7tpwas being allowed by the frontend, but rejected by the backend.The goal here is to make the FE & BE* are stick to the same regex rule.
*(the backend itself doesn't validate, it defers to a function in data-models. So really we're matching that.)
There's a few tests updated and removed: ones that disallowed not having a space, or not using capital letters. The backend/data-models normalises what it's given, so postcodes like bn16aa will get transformed into BN1 6AA.
To test it works, we should NOT be able to use the above postcode in either form (the main page, or the /update page)
Last point: I did this a year ago when I had an IDE rule that strips whitespace. While I don't have that rule enabled anymore, I do still want to keep the many whitespace removal changes here. A noisier diff, but it is correct as that is errant whitespace and it shouldn't be here. I will die on this hill