Replace GetOsPageSize() with minipal_getpagesize() in CoreCLR

[pavelsavara]

Fixes #127550

Summary

Remove the GetOsPageSize() wrapper from utilcode and replace all call sites in CoreCLR with the new minipal_getpagesize() API introduced in #127328.

Motivation

PR #127328 introduced minipal_getpagesize() in src/native/minipal/ospagesize.h as the canonical way to query the OS page size across all platforms:

• Windows: inline constant 4096 (no syscall)
• WASM: inline constant 16384 (reduced from the 64KB memory.grow granularity)
• Unix: cached getpagesize() result (queried once per process)

The old GetOsPageSize() in src/coreclr/utilcode/util.cpp duplicated this logic with slightly different behavior (used GetSystemInfo().dwAllocationGranularity on the PAL path, hardcoded 0x1000 on Windows). Consolidating on the minipal version eliminates the duplication and ensures consistent page-size semantics, particularly for WASM where the correct value is 16KB.

Changes

• Removed GetOsPageSize() and GetOsPageSizeUncached() definitions from src/coreclr/utilcode/util.cpp
• Removed GetOsPageSize() declaration from src/coreclr/inc/utilcode.h
• Added #include <minipal/ospagesize.h> to utilcode.h (covers all VM/utilcode consumers) and to the two PAL test files that don't include utilcode.h
• Replaced all GetOsPageSize() call sites with minipal_getpagesize(), applying (uint32_t) casts where the target storage or comparison type is 32-bit
• Fixed HARD_GUARD_REGION_SIZE being defined twice in threads.h (removed the redundant first definition)
• Fixed SIZEOF_DEFAULT_STACK_GUARANTEE and HARD_GUARD_REGION_SIZE macro hygiene (wrapped in outer parentheses, removed pointless 1 * multiplier)

[dotnet-policy-service]

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR standardizes CoreCLR’s “OS page size” queries by removing the utilcode GetOsPageSize() wrapper and migrating call sites to the canonical minipal_getpagesize() API (including updating a few page-size-related macros and PAL tests). This helps ensure consistent semantics across platforms (notably WASM’s 16KB page size behavior).

Changes:

• Removed GetOsPageSize() / GetOsPageSizeUncached() from utilcode and updated all CoreCLR call sites to use minipal_getpagesize().
• Added/propagated minipal/ospagesize.h inclusion (via utilcode.h and directly in a couple PAL tests).
• Cleaned up some page-size-related macro definitions (duplicate define removal + extra parentheses).

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/native/managed/cdac/tests/PrecodeStubsTests.cs	Updates embedded native-code comment to reflect minipal_getpagesize().
src/coreclr/vm/virtualcallstub.cpp	Uses minipal_getpagesize() for reserve/commit alignment and page computations.
src/coreclr/vm/threads.h	Replaces page-size macros with minipal_getpagesize() and removes duplicate define.
src/coreclr/vm/threads.cpp	Replaces page-size uses in asserts/debug logging/guard-page math with minipal_getpagesize().
src/coreclr/vm/peimagelayout.cpp	Uses minipal_getpagesize() for mapping alignment and validation.
src/coreclr/vm/loaderallocator.cpp	Uses minipal_getpagesize() for collectible heap sizing constants.
src/coreclr/vm/jitinterface.h	Updates UNIX null-check offset definition to use minipal_getpagesize().
src/coreclr/vm/jitinterface.cpp	Reports osPageSize via minipal_getpagesize() in EE info.
src/coreclr/vm/i386/jitinterfacex86.cpp	Updates debug asserts to use minipal_getpagesize().
src/coreclr/vm/hosting.cpp	Updates UEF section page calculations to use minipal_getpagesize().
src/coreclr/vm/frames.cpp	Updates “frame order” relaxation logic to use minipal_getpagesize().
src/coreclr/vm/excep.h	Uses minipal_getpagesize() for NULL_AREA_SIZE on UNIX.
src/coreclr/vm/debughelp.cpp	Uses minipal_getpagesize() when walking/touching pages for readability checks.
src/coreclr/vm/codeman.h	Updates rounding-to-page macros and comments to use minipal_getpagesize().
src/coreclr/vm/ceemain.cpp	Aligns mini-metadata buffer sizing using minipal_getpagesize().
src/coreclr/vm/appdomain.hpp	Updates loader heap reserve/commit sizing macros to use minipal_getpagesize().
src/coreclr/utilcode/util.cpp	Removes the old GetOsPageSize* implementations.
src/coreclr/utilcode/loaderheap.cpp	Uses minipal_getpagesize() for commit sizing alignment.
src/coreclr/utilcode/interleavedloaderheap.cpp	Uses minipal_getpagesize() for alignment/assertions.
src/coreclr/utilcode/explicitcontrolloaderheap.cpp	Uses minipal_getpagesize() for commit block sizing and alignment.
src/coreclr/utilcode/executableallocator.cpp	Uses minipal_getpagesize() when randomizing preferred range start.
src/coreclr/utilcode/dacutil.cpp	Uses minipal_getpagesize() for page-boundary-limited reads.
src/coreclr/utilcode/clrhost_nodependencies.cpp	Uses minipal_getpagesize() for page-aligned region checks.
src/coreclr/pal/tests/palsuite/miscellaneous/IsBadWritePtr/test3/test3.cpp	Includes ospagesize.h and uses minipal_getpagesize() in allocations/checks.
src/coreclr/pal/tests/palsuite/miscellaneous/IsBadWritePtr/test2/test2.cpp	Includes ospagesize.h and uses minipal_getpagesize() in allocations/checks.
src/coreclr/inc/utilcode.h	Includes minipal/ospagesize.h and removes GetOsPageSize() declaration.
src/coreclr/inc/pedecoder.inl	Uses minipal_getpagesize() when temporarily setting decoder size to 2 pages.
src/coreclr/inc/loaderheap.h	Updates stub code page sizing logic to use minipal_getpagesize().
src/coreclr/debug/di/shimlocaldatatarget.cpp	Uses minipal_getpagesize() for page-boundary-limited reads.
src/coreclr/debug/daccess/enummem.cpp	Uses minipal_getpagesize() for page-chunked memory reporting.

[Copilot]

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated no new comments.

[jkotas]

VirtualAlloc argument is SIZE_T. This cast should be unnecessary. Can we do a pass to delete the uint32_t casts where it is not necessary or where it is easy to fix the code to avoid it?

(Alternatively, I am wondering whether it would be better for minipal_getpagesize to return uint32_t to avoid these casts.